Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 797903002: Upstream save passwords and search engine preferences. (Closed)

Created:
6 years ago by newt (away)
Modified:
6 years ago
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream save passwords and search engine preferences. BUG=428869 Committed: https://crrev.com/182e87591fc78c589a09423fd5ad3a4789d050e0 Cr-Commit-Position: refs/heads/master@{#308147}

Patch Set 1 #

Patch Set 2 : original (broken) version of SearchEnginePreference.java #

Patch Set 3 : fixed SearchEnginePreference.java #

Unified diffs Side-by-side diffs Delta from patch set Stats (+830 lines, -0 lines) Patch
A chrome/android/java/res/layout/password_entry_editor.xml View 1 chunk +79 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromeBaseListPreference.java View 1 chunk +47 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromeBasePreference.java View 1 chunk +60 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreference.java View 2 1 chunk +107 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/preferences/password/ManageSavedPasswordsPreferences.java View 1 chunk +256 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java View 1 chunk +91 lines, -0 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 2 chunks +28 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/preferences/PreferencesTest.java View 2 chunks +76 lines, -0 lines 0 comments Download
A chrome/android/javatests/src/org/chromium/chrome/browser/preferences/password/SavedPasswordsPreferencesTest.java View 1 chunk +80 lines, -0 lines 0 comments Download
M chrome/android/shell/res/xml/chrome_shell_main_preferences.xml View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
newt (away)
PTAL Everything is copy-pasted except for: - The save password tests, which have been rewritten: ...
6 years ago (2014-12-12 17:22:41 UTC) #2
aurimas (slooooooooow)
lgtm
6 years ago (2014-12-12 18:30:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797903002/40001
6 years ago (2014-12-12 18:52:28 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-12 20:05:12 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-12 20:06:04 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/182e87591fc78c589a09423fd5ad3a4789d050e0
Cr-Commit-Position: refs/heads/master@{#308147}

Powered by Google App Engine
This is Rietveld 408576698