Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 797873002: Remove style element counting in ShadowRoot. (Closed)

Created:
6 years ago by esprehn
Modified:
6 years ago
Reviewers:
ojan, eseidel
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove style element counting in ShadowRoot. This optimization doesn't make sense, all it does is avoid adding the ScopedStyleResolver for the ShadowRoot when looking for host styles, but having that extra resolver shouldn't be slow, and in sky it's very rare to have a ShadowRoot without styles unlike on the web where <input> is very common and gets its style from the UA instead of from a <style> like a normal component. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/fd648da8b44d33808ae022168830c299849a87bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -27 lines) Patch
M sky/engine/core/css/resolver/StyleResolver.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M sky/engine/core/dom/shadow/ShadowRoot.h View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/dom/shadow/ShadowRoot.cpp View 2 chunks +0 lines, -12 lines 0 comments Download
M sky/engine/core/html/HTMLStyleElement.cpp View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
esprehn
6 years ago (2014-12-12 00:48:36 UTC) #2
ojan
lgtm
6 years ago (2014-12-12 01:01:02 UTC) #3
esprehn
6 years ago (2014-12-12 01:34:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fd648da8b44d33808ae022168830c299849a87bd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698