Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 797853002: Expose the CSSSupportsRule interface object (Closed)

Created:
6 years ago by philipj_slow
Modified:
6 years ago
Reviewers:
Timothy Loh
CC:
blink-reviews, arv+blink, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, Inactive, darktears, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Expose the CSSSupportsRule interface object It appears to be an historical accident that this is not exposed, as originally one had to explicitly expose interface objects: https://chromiumcodereview.appspot.com/14179013 Firefox Nightly also exposes this. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187116

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M LayoutTests/css3/supports-cssom.html View 3 chunks +4 lines, -0 lines 0 comments Download
M LayoutTests/css3/supports-cssom-expected.txt View 3 chunks +4 lines, -0 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/css/CSSSupportsRule.idl View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
philipj_slow
PTAL
6 years ago (2014-12-12 11:54:58 UTC) #2
Timothy Loh
On 2014/12/12 11:54:58, philipj wrote: > PTAL lgtm
6 years ago (2014-12-14 23:20:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797853002/1
6 years ago (2014-12-15 06:47:57 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-15 06:50:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187116

Powered by Google App Engine
This is Rietveld 408576698