Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issue 797843003: Remove src/trusted/manifest_name_service_proxy/ (old open_resource() impl) (Closed)

Created:
6 years ago by Mark Seaborn
Modified:
5 years, 11 months ago
CC:
native-client-reviews_googlegroups.com, teravest
Target Ref:
refs/remotes/origin/master
Project:
nacl
Visibility:
Public.

Description

Remove src/trusted/manifest_name_service_proxy/ (old open_resource() impl) This was part of the old SRPC-based implementation of open_resource(), which is no longer used. * This removes the hookup in nacl_secure_service.c where "ManifestNameService" was registered. * This removes srpc_nameservice_test.c, which checked that it was possible to get a "ManifestNameService" connection and initialize SRPC on it (but tested it no further than that). srpc_nameservice_test.c also contained some dead code: There was a "rngdump" method for testing the "SecureRandom" service (which was removed earlier), but "rngdump" was never called. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3864 TEST=Chromium trybots + NaCl trybots R=jvoung@chromium.org, teravest@chromium.org Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=da8dfa4e7c67c2a59861b97c94e28e0cf6ee9cdd

Patch Set 1 #

Patch Set 2 : Retry #

Patch Set 3 : Fix Scons build #

Patch Set 4 : Remove test #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -883 lines) Patch
M SConstruct View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M site_scons/site_tools/library_deps.py View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D src/trusted/manifest_name_service_proxy/BUILD.gn View 1 chunk +0 lines, -21 lines 0 comments Download
D src/trusted/manifest_name_service_proxy/build.scons View 1 chunk +0 lines, -12 lines 0 comments Download
D src/trusted/manifest_name_service_proxy/manifest_name_service_proxy.gyp View 1 chunk +0 lines, -64 lines 0 comments Download
D src/trusted/manifest_name_service_proxy/manifest_proxy.h View 1 chunk +0 lines, -76 lines 0 comments Download
D src/trusted/manifest_name_service_proxy/manifest_proxy.c View 1 chunk +0 lines, -390 lines 0 comments Download
M src/trusted/service_runtime/BUILD.gn View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M src/trusted/service_runtime/build.scons View 1 2 5 chunks +0 lines, -5 lines 0 comments Download
M src/trusted/service_runtime/nacl_secure_service.c View 3 chunks +0 lines, -31 lines 0 comments Download
M src/trusted/service_runtime/service_runtime.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M tests/nameservice/nacl.scons View 1 2 3 1 chunk +0 lines, -31 lines 0 comments Download
D tests/nameservice/srpc_nameservice_test.c View 1 2 3 1 chunk +0 lines, -242 lines 2 comments Download
D tests/nameservice/srpc_nameservice_test.stdin View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
D tests/nameservice/srpc_nameservice_test.stdout View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
Mark Seaborn
6 years ago (2014-12-17 23:53:29 UTC) #2
Mark Seaborn
Looks like I sent this out too soon; sorry. There are some NaCl-side tests that ...
6 years ago (2014-12-18 00:07:17 UTC) #3
Mark Seaborn
This is ready for commit now. Please take a look.
5 years, 11 months ago (2015-01-08 21:53:05 UTC) #4
teravest
lgtm
5 years, 11 months ago (2015-01-09 17:34:29 UTC) #6
jvoung (off chromium)
not terribly familiar with this code =), but LGTM https://codereview.chromium.org/797843003/diff/60001/tests/nameservice/srpc_nameservice_test.c File tests/nameservice/srpc_nameservice_test.c (left): https://codereview.chromium.org/797843003/diff/60001/tests/nameservice/srpc_nameservice_test.c#oldcode178 tests/nameservice/srpc_nameservice_test.c:178: ...
5 years, 11 months ago (2015-01-09 17:36:40 UTC) #7
Mark Seaborn
https://codereview.chromium.org/797843003/diff/60001/tests/nameservice/srpc_nameservice_test.c File tests/nameservice/srpc_nameservice_test.c (left): https://codereview.chromium.org/797843003/diff/60001/tests/nameservice/srpc_nameservice_test.c#oldcode178 tests/nameservice/srpc_nameservice_test.c:178: "ManifestNameService", O_RDWR, On 2015/01/09 17:36:40, jvoung wrote: > I ...
5 years, 11 months ago (2015-01-10 07:00:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797843003/60001
5 years, 11 months ago (2015-01-10 07:01:48 UTC) #10
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true in order for the CQ ...
5 years, 11 months ago (2015-01-10 07:01:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797843003/60001
5 years, 11 months ago (2015-01-10 07:09:49 UTC) #14
commit-bot: I haz the power
Failed to apply the patch.
5 years, 11 months ago (2015-01-10 07:09:53 UTC) #16
Mark Seaborn
5 years, 11 months ago (2015-01-11 17:13:15 UTC) #17
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
da8dfa4e7c67c2a59861b97c94e28e0cf6ee9cdd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698