chrome/browser/extensions/syncable_extension_settings_storage.cc - Issue 7978051: Fix memory leak in SyncableExtensionSettingsStorage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/syncable_extension_settings_storage.cc

Issue 7978051: Fix memory leak in SyncableExtensionSettingsStorage. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/syncable_extension_settings_storage.cc

diff --git a/chrome/browser/extensions/syncable_extension_settings_storage.cc b/chrome/browser/extensions/syncable_extension_settings_storage.cc

index 137a6cb223783a420d1ce5589eaf57c25609f123..173ce28166785c819a2d80d34cc822dbb7e296ed 100644

--- a/chrome/browser/extensions/syncable_extension_settings_storage.cc

+++ b/chrome/browser/extensions/syncable_extension_settings_storage.cc

@@ -185,6 +185,9 @@ SyncError SyncableExtensionSettingsStorage::OverwriteLocalSettingsWithSync(

changes.push_back(

ExtensionSettingSyncData(

SyncChange::ACTION_UPDATE, extension_id_, *it, sync_value));

+ } else {

+ // Values are the same, no change needed.

+ delete sync_value;

}

} else {

// Not synced, delete local setting.

« no previous file with comments | « no previous file | tools/heapcheck/suppressions.txt » ('j') | no next file with comments »