Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
797793005:
Add rTree factory to beginRecording call in RasterBufferImpl ctor (Closed)
|
Created:
5 years, 11 months ago by robertphillips Modified:
5 years, 11 months ago CC:
chromium-reviews, cc-bugs_chromium.org, hcm1 Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd rTree factory to beginRecording call in RasterBufferImpl ctor
Although the sub-pictures already have the layer hoisting
data, Skia cannot access it unless the wrapping picture has
also gone through the hoisting analysis. Fortunately or
unfortunately, this is piggy-backed upon BBH creation (so
providing the kComputeSaveLayerInfo_RecordFlag by itself
is not sufficient).
BUG=383085
Committed: https://crrev.com/9b891315f7af505fd9d0a4078589adf00925b518
Cr-Commit-Position: refs/heads/master@{#310143}
Patch Set 1 #Patch Set 2 : the beginRecording call has moved to gpu_rasterizer.cc #Messages
Total messages: 22 (9 generated)
robertphillips@google.com changed reviewers: + enne@chromium.org, jamesr@chromium.org
hcm@google.com changed reviewers: + vangelis@chromium.org
robertphillips@google.com changed reviewers: + nduca@chromium.org
robertphillips@google.com changed reviewers: + danakj@chromium.org
danakj@chromium.org changed reviewers: + vmpstr@chromium.org - enne@chromium.org, jamesr@chromium.org, nduca@chromium.org, vangelis@chromium.org
/toss to vmpstr
vmpstr@chromium.org changed reviewers: + vmiura@chromium.org
Is this actually going to enable layer hoisting? If so, do we want this in 41? +vmiura, FYI
I think it is too close to the branch point so I am disabling it (in a clearer fashion) in: https://codereview.chromium.org/835343002/ (Disable layer hoisting). I wouldn't land this CL until after that one.
On 2015/01/06 18:41:57, robertphillips wrote: > I think it is too close to the branch point so I am disabling it (in a clearer > fashion) in: https://codereview.chromium.org/835343002/ (Disable layer > hoisting). > > I wouldn't land this CL until after that one. Ah, makes sense. lgtm.
The CQ bit was checked by robertphillips@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797793005/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...) android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...) android_chromium_gn_compile_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...) android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...) android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...) android_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...) chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...) win_chromium_x64_rel_ng on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by robertphillips@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797793005/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/9b891315f7af505fd9d0a4078589adf00925b518 Cr-Commit-Position: refs/heads/master@{#310143} |
