Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: content/browser/child_process_launcher.cc

Issue 797783002: Android: CHECK() for supported child process types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/child_process_launcher.cc
diff --git a/content/browser/child_process_launcher.cc b/content/browser/child_process_launcher.cc
index 636fd88fd0354f7bb64adeee0e2794301ed37e90..5f708b87922e918ab1a75b6433e8b12fc6a1106e 100644
--- a/content/browser/child_process_launcher.cc
+++ b/content/browser/child_process_launcher.cc
@@ -181,6 +181,18 @@ void ChildProcessLauncher::Context::Launch(
client_ = client;
#if defined(OS_ANDROID)
+ // We currently only support renderer and gpu child processes.
+ std::string process_type =
+ cmd_line->GetSwitchValueASCII(switches::kProcessType);
+ CHECK_NE(switches::kPluginProcess, process_type);
+ CHECK_NE(switches::kPpapiBrokerProcess, process_type);
+ CHECK_NE(switches::kPpapiPluginProcess, process_type);
+ CHECK_NE(switches::kSandboxIPCProcess, process_type);
+ CHECK_NE(switches::kUtilityProcess, process_type);
+ CHECK_NE(switches::kZygoteProcess, process_type);
+ CHECK(process_type == switches::kGpuProcess ||
+ process_type == switches::kRendererProcess);
+
// We need to close the client end of the IPC channel to reliably detect
// child termination. We will close this fd after we create the child
// process which is asynchronous on Android.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698