cc/resources/picture.cc - Issue 797753003: use picture->cullRect instead of (deprecated) width/height

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/resources/picture.cc

Issue 797753003: use picture->cullRect instead of (deprecated) width/height (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use SkIRectToRect helper Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/resources/picture.cc

diff --git a/cc/resources/picture.cc b/cc/resources/picture.cc

index 6530866d6a03dce9a4d6374a53693fe70f73cdaa..10591b9b1412ce13a7bbecda4b546df5e56ac83b 100644

--- a/cc/resources/picture.cc

+++ b/cc/resources/picture.cc

@@ -121,7 +121,8 @@ scoped_refptr<Picture> Picture::CreateFromSkpValue(const base::Value* value) {

if (skpicture == NULL)

return NULL;

- gfx::Rect layer_rect(skpicture->width(), skpicture->height());

+ const SkIRect skr = skpicture->cullRect().roundOut();

+ gfx::Rect layer_rect(gfx::SkIRectToRect(skr));

danakj 2014/12/12 18:53:02 nit: just do gfx::Rect layer_rect(gfx::SkIRectToRe

reed1 2014/12/12 19:12:02 Done.

return make_scoped_refptr(new Picture(skpicture, layer_rect));

}

« no previous file with comments | « no previous file | skia/config/SkUserConfig.h » ('j') | skia/ext/pixel_ref_utils.cc » ('J')