Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 797753003: use picture->cullRect instead of (deprecated) width/height (Closed)

Created:
6 years ago by reed1
Modified:
6 years ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

use picture->cullRect instead of (deprecated) width/height BUG= Committed: https://crrev.com/ba7b16f7a017e6b044e1c9a087f0681d93565e1d Cr-Commit-Position: refs/heads/master@{#308198}

Patch Set 1 #

Total comments: 2

Patch Set 2 : use SkIRectToRect helper #

Total comments: 4

Patch Set 3 : address comments from #2 #

Patch Set 4 : fix android call-site #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M android_webview/native/aw_picture.cc View 1 2 3 4 5 1 chunk +4 lines, -3 lines 0 comments Download
M cc/resources/picture.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M skia/config/SkUserConfig.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M skia/ext/pixel_ref_utils.cc View 1 2 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 26 (10 generated)
reed2
need OWNERS for cc/resources
6 years ago (2014-12-12 02:54:59 UTC) #3
danakj
https://codereview.chromium.org/797753003/diff/1/cc/resources/picture.cc File cc/resources/picture.cc (right): https://codereview.chromium.org/797753003/diff/1/cc/resources/picture.cc#newcode125 cc/resources/picture.cc:125: gfx::Rect layer_rect(skr.x(), skr.y(), skr.width(), skr.height()); You can use this ...
6 years ago (2014-12-12 17:11:37 UTC) #5
reed1
ptal https://codereview.chromium.org/797753003/diff/1/cc/resources/picture.cc File cc/resources/picture.cc (right): https://codereview.chromium.org/797753003/diff/1/cc/resources/picture.cc#newcode125 cc/resources/picture.cc:125: gfx::Rect layer_rect(skr.x(), skr.y(), skr.width(), skr.height()); On 2014/12/12 17:11:37, ...
6 years ago (2014-12-12 18:51:35 UTC) #6
danakj
cc LGTM https://codereview.chromium.org/797753003/diff/20001/cc/resources/picture.cc File cc/resources/picture.cc (right): https://codereview.chromium.org/797753003/diff/20001/cc/resources/picture.cc#newcode125 cc/resources/picture.cc:125: gfx::Rect layer_rect(gfx::SkIRectToRect(skr)); nit: just do gfx::Rect layer_rect(gfx::SkIRectToRect(skpicture->cullRect().roundOut())); ...
6 years ago (2014-12-12 18:53:02 UTC) #7
danakj
https://codereview.chromium.org/797753003/diff/20001/skia/ext/pixel_ref_utils.cc File skia/ext/pixel_ref_utils.cc (right): https://codereview.chromium.org/797753003/diff/20001/skia/ext/pixel_ref_utils.cc#newcode363 skia/ext/pixel_ref_utils.cc:363: // want to draw the picture pinned against our ...
6 years ago (2014-12-12 18:53:53 UTC) #8
reed1
https://codereview.chromium.org/797753003/diff/20001/cc/resources/picture.cc File cc/resources/picture.cc (right): https://codereview.chromium.org/797753003/diff/20001/cc/resources/picture.cc#newcode125 cc/resources/picture.cc:125: gfx::Rect layer_rect(gfx::SkIRectToRect(skr)); On 2014/12/12 18:53:02, danakj wrote: > nit: ...
6 years ago (2014-12-12 19:12:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797753003/40001
6 years ago (2014-12-12 19:13:38 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/41565) android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/30297)
6 years ago (2014-12-12 19:47:33 UTC) #13
reed1
need OWNER for android_view
6 years ago (2014-12-12 20:04:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797753003/100001
6 years ago (2014-12-12 21:14:48 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/30152)
6 years ago (2014-12-12 21:29:38 UTC) #19
reed1
adding more android_webview OWNERS
6 years ago (2014-12-12 21:39:58 UTC) #21
boliu
On 2014/12/12 21:39:58, reed1 wrote: > adding more android_webview OWNERS lgtm
6 years ago (2014-12-12 21:42:10 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797753003/100001
6 years ago (2014-12-12 22:14:16 UTC) #24
commit-bot: I haz the power
Committed patchset #6 (id:100001)
6 years ago (2014-12-13 00:01:11 UTC) #25
commit-bot: I haz the power
6 years ago (2014-12-13 00:01:54 UTC) #26
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/ba7b16f7a017e6b044e1c9a087f0681d93565e1d
Cr-Commit-Position: refs/heads/master@{#308198}

Powered by Google App Engine
This is Rietveld 408576698