Update app list search box menu when Users changes

ui/app_list/views/search_box_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/app_list/views/search_box_view.h"
 
 #include <algorithm>
 
 #include "grit/ui_resources.h"
 #include "ui/app_list/app_list_model.h"
@@ skipping 169 matching lines @@
   return handled;
 }
 
 void SearchBoxView::ButtonPressed(views::Button* sender,
                                   const ui::Event& event) {
   DCHECK(!speech_button_ && sender == speech_button_);
   view_delegate_->ToggleSpeechRecognition();
 }
 
 void SearchBoxView::OnMenuButtonClicked(View* source, const gfx::Point& point) {
-  if (!menu_)
-    menu_.reset(new AppListMenuViews(view_delegate_));
+  // Always regenerate the menu in case view_delegate_->GetUsers() has changed.

[tapted, 2013/11/26 00:40:07]

So, mac isn't affected by the checkmark-not-moving bug, but it is affected by
the "menu not updated when profile added/removed" bug.

Unfortunately Mac's menu_controller works a bit different -- an `NSMenu` is
populated and attached to the button itself, so I don't think there's a nice way
to intercept the 'click' the way you can for context menus.

But there is already an observer interface -- OnAppListModelSigninStatusChanged
-- which triggers a menu refresh. Hacky fix: just remove the `signed_in_ ==
signed_in` check from

void AppListModel::SetSignedIn(bool signed_in) {
  if (signed_in_ == signed_in)
    return;

/* .. */
}

I think this will fix Mac. Certainly, deleting a profile, then switching the app
launcher to a profile that isn't signed in and back will refresh the menu.

So, to make the fix less hacky, WDYT about just changing
`OnAppListModelSigninStatusChanged` to
`AppListModelObserver::OnAppListModelProfileChanged` ?

It looks like void AppListView::OnSigninStatusChanged() does
`app_list_main_view_->search_box_view()->InvalidateMenu();` so other platforms
should be covered too.

+  menu_.reset(new AppListMenuViews(view_delegate_));
 
   const gfx::Point menu_location =
       menu_button_->GetBoundsInScreen().bottom_right() +
       gfx::Vector2d(kMenuXOffsetFromButton, kMenuYOffsetFromButton);
   menu_->RunMenuAt(menu_button_, menu_location);
 }
 
 void SearchBoxView::IconChanged() {
   icon_view_->SetImage(model_->search_box()->icon());
 }
@@ skipping 33 matching lines @@
 void SearchBoxView::SelectionModelChanged() {
   search_box_->SelectSelectionModel(model_->search_box()->selection_model());
 }
 
 void SearchBoxView::TextChanged() {
   search_box_->SetText(model_->search_box()->text());
   NotifyQueryChanged();
 }
 
 }  // namespace app_list