Chromium Code Reviews
Help | Chromium Project | Sign in
(178)

Issue 7977043: Turn off checklicenses until it's done more efficiently. Linux try runs now take an hour. This ad... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Turn off checklicenses until it's done more efficiently. Linux try runs now take an hour. This adds anywhere from 6 mintues to 10 minutes (when it times out), which is an unacceptable time. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102420

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tools/checklicenses/checklicenses.py View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 5 (0 generated)
jam
3 years, 10 months ago (2011-09-22 03:16:58 UTC) #1
Paweł Hajdan Jr.
I'd prefer to avoid disabling it temporarily, to prevent further regressions. I'm working on making ...
3 years, 10 months ago (2011-09-22 16:07:29 UTC) #2
jam
Sure, waiting till end of day to see if slowness is fixed seems reasonable. I ...
3 years, 10 months ago (2011-09-22 16:22:02 UTC) #3
jam
btw I just looked through all the runs over the last few hours that had ...
3 years, 10 months ago (2011-09-23 01:34:42 UTC) #4
nsylvain
3 years, 10 months ago (2011-09-23 07:11:54 UTC) #5
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 5fa3ca5