Chromium Code Reviews
Help | Chromium Project | Sign in
(893)

Issue 7977043: Turn off checklicenses until it's done more efficiently. Linux try runs now take an hour. This ad... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 7 months ago by jam
Modified:
2 years, 7 months ago
CC:
chromium-reviews_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Turn off checklicenses until it's done more efficiently. Linux try runs now take an hour. This adds anywhere from 6 mintues to 10 minutes (when it times out), which is an unacceptable time.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102420

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Lint Patch
M tools/checklicenses/checklicenses.py View 1 2 1 chunk +5 lines, -0 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 5
jam
2 years, 7 months ago #1
Paweł Hajdan Jr.
I'd prefer to avoid disabling it temporarily, to prevent further regressions. I'm working on making ...
2 years, 7 months ago #2
jam
Sure, waiting till end of day to see if slowness is fixed seems reasonable. I ...
2 years, 7 months ago #3
jam
btw I just looked through all the runs over the last few hours that had ...
2 years, 7 months ago #4
nsylvain
2 years, 7 months ago #5
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6