Implement SingleThreadProxy CommitVSyncParameters

Implement SingleThreadProxy CommitVSyncParameters

Implement CommitVSyncParameter in SingleThreadProxy like ThreadProxy.

BUG=372086
Committed: https://crrev.com/af17af4b4a1a053defe67190d66109dffee7f296
Cr-Commit-Position: refs/heads/master@{#308436}

[weiliangc, 2014-12-15 16:57:10]

weiliangc@chromium.org changed reviewers:
+ brianderson@chromium.org

[danakj, 2014-12-15 17:03:12]

> Implement CommitVSyncParameter in SinglThreadProxy like ThreadProxy.

typo

On Mon, Dec 15, 2014 at 8:57 AM, <weiliangc@chromium.org> wrote:

> Reviewers: brianderson,
>
> Description:
> Implement SingleThreadProxy CommitVSyncParameters
>
> Implement CommitVSyncParameter in SinglThreadProxy like ThreadProxy.
>
> BUG=372086
>
> Please review this at https://codereview.chromium.org/797693004/
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+7, -1 lines):
>   M cc/trees/single_thread_proxy.h
>   M cc/trees/single_thread_proxy.cc
>
>
> Index: cc/trees/single_thread_proxy.cc
> diff --git a/cc/trees/single_thread_proxy.cc b/cc/trees/single_thread_
> proxy.cc
> index 6498f0e0996ce49b310eb9a1c7a5d83bcfbfe4df..
> 816050bb04ca6c9d3f058fec687140ee2a7429d5 100644
> --- a/cc/trees/single_thread_proxy.cc
> +++ b/cc/trees/single_thread_proxy.cc
> @@ -463,6 +463,12 @@ void SingleThreadProxy::
> DidLoseOutputSurfaceOnImplThread() {
>      scheduler_on_impl_thread_->DidLoseOutputSurface();
>  }
>
> +void SingleThreadProxy::CommitVSyncParameters(base::TimeTicks timebase,
> +                                              base::TimeDelta interval) {
> +  if (scheduler_on_impl_thread_)
> +    scheduler_on_impl_thread_->CommitVSyncParameters(timebase, interval);
> +}
> +
>  void SingleThreadProxy::DidSwapBuffersOnImplThread() {
>    TRACE_EVENT0("cc", "SingleThreadProxy::DidSwapBuffersOnImplThread");
>    if (scheduler_on_impl_thread_)
> Index: cc/trees/single_thread_proxy.h
> diff --git a/cc/trees/single_thread_proxy.h b/cc/trees/single_thread_
> proxy.h
> index d3f41a5733e89d1b6be99c7d03c53afc786b0a7d..
> 82691a215f0f1a02c81728c33138108cc5d4e7d6 100644
> --- a/cc/trees/single_thread_proxy.h
> +++ b/cc/trees/single_thread_proxy.h
> @@ -82,7 +82,7 @@ class CC_EXPORT SingleThreadProxy : public Proxy,
>    void UpdateRendererCapabilitiesOnImplThread() override;
>    void DidLoseOutputSurfaceOnImplThread() override;
>    void CommitVSyncParameters(base::TimeTicks timebase,
> -                             base::TimeDelta interval) override {}
> +                             base::TimeDelta interval) override;
>    void SetEstimatedParentDrawTime(base::TimeDelta draw_time) override {}
>    void SetMaxSwapsPendingOnImplThread(int max) override {}
>    void DidSwapBuffersOnImplThread() override;
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[enne (OOO), 2014-12-15 19:24:31]

enne@chromium.org changed reviewers:
+ enne@chromium.org

[enne (OOO), 2014-12-15 19:24:31]

lgtm

[enne (OOO), 2014-12-15 19:25:15]

https://codereview.chromium.org/797693004/diff/1/cc/trees/single_thread_proxy.cc
File cc/trees/single_thread_proxy.cc (right):

https://codereview.chromium.org/797693004/diff/1/cc/trees/single_thread_proxy...
cc/trees/single_thread_proxy.cc:468: if (scheduler_on_impl_thread_)
Actually, should this be a DCHECK? Does this get called by embedders not using
the scheduler? Or before the scheduler is created?

[brianderson, 2014-12-15 19:59:50]

lgtm

https://codereview.chromium.org/797693004/diff/1/cc/trees/single_thread_proxy.cc
File cc/trees/single_thread_proxy.cc (right):

https://codereview.chromium.org/797693004/diff/1/cc/trees/single_thread_proxy...
cc/trees/single_thread_proxy.cc:468: if (scheduler_on_impl_thread_)
On 2014/12/15 19:25:15, enne wrote:
> Actually, should this be a DCHECK? Does this get called by embedders not using
> the scheduler? Or before the scheduler is created?

I wouldn't expect this to get called before the scheduler is created.

However, I don't think there's logic in any of the many origins of this call
that considers what kind of cc::Proxy is used.

Either way, I don't think we need to make this a DCHECK. For configs where we
would hit the DCHECK, I don't see us caring about performance cost of a message
we don't listen to.

[weiliangc, 2014-12-15 21:21:21]

The CQ bit was checked by weiliangc@chromium.org

[commit-bot: I haz the power, 2014-12-15 21:22:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/797693004/1

[commit-bot: I haz the power, 2014-12-15 22:17:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-12-15 22:17:50]

Patchset 1 (id:??) landed as
https://crrev.com/af17af4b4a1a053defe67190d66109dffee7f296
Cr-Commit-Position: refs/heads/master@{#308436}