Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 797693002: easy-unlock: Get rid of extra flag. (Closed)

Created:
6 years ago by xiyuan
Modified:
6 years ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

easy-unlock: Get rid of extra flag. BUG=439638 Committed: https://crrev.com/12076f74c1a68c011c37656d74500e492b7dc868 Cr-Commit-Position: refs/heads/master@{#308027}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -19 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -7 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/proximity_auth/switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
xiyuan
6 years ago (2014-12-11 16:43:25 UTC) #2
Ilya Sherman
LGTM -- yey =) https://codereview.chromium.org/797693002/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/797693002/diff/1/chrome/app/generated_resources.grd#newcode6592 chrome/app/generated_resources.grd:6592: + Do not use Smart ...
6 years ago (2014-12-11 23:34:52 UTC) #3
xiyuan
https://codereview.chromium.org/797693002/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/797693002/diff/1/chrome/app/generated_resources.grd#newcode6592 chrome/app/generated_resources.grd:6592: + Do not use Smart Lock, which allows you ...
6 years ago (2014-12-11 23:38:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797693002/20001
6 years ago (2014-12-11 23:40:10 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-12 02:14:37 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-12 02:15:23 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/12076f74c1a68c011c37656d74500e492b7dc868
Cr-Commit-Position: refs/heads/master@{#308027}

Powered by Google App Engine
This is Rietveld 408576698