Issue 797613004: Add GN interactive UI tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 797613004: Add GN interactive UI tests. (Closed)

Created:
5 years, 11 months ago by brettw

Modified:
5 years, 11 months ago

Reviewers:
dpranke

CC:
chromium-reviews, kalyank, sadrul, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Add GN interactive UI tests. Reland of https://codereview.chromium.org/795373005/ with fix. TBR=dpranke Committed: https://crrev.com/6c1a7728eb968dfc8c1e5ac51c1ce6a5e11feb79 Cr-Commit-Position: refs/heads/master@{#310072}

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+300 lines, -38 lines)			Patch
M	ash/ash_resources.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	build/config/linux/BUILD.gn	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View		11 chunks	+37 lines, -32 lines	0 comments	Download
M	chrome/test/BUILD.gn	View		2 chunks	+246 lines, -6 lines	0 comments	Download
M	chromeos/BUILD.gn	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	extensions/BUILD.gn	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	google_apis/google_apis.gyp	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	third_party/mesa/BUILD.gn	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/base/BUILD.gn	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797613004/20002

5 years, 11 months ago (2015-01-06 07:20:07 UTC) #3

commit-bot: I haz the power

5 years, 11 months ago (2015-01-06 08:35:32 UTC) #5

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/6c1a7728eb968dfc8c1e5ac51c1ce6a5e11feb79
Cr-Commit-Position: refs/heads/master@{#310072}