build/config/gcc/gcc_version.gni - Issue 797593002: Fix gcc_version.gni to determine target GCC version for MIPSEL Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/gcc/gcc_version.gni

Issue 797593002: Fix gcc_version.gni to determine target GCC version for MIPSEL Linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comment: Removed TODO Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/gcc/gcc_version.gni

diff --git a/build/config/gcc/gcc_version.gni b/build/config/gcc/gcc_version.gni

index 2ecc54a4d7536bc4c849e89261a2b25cbaa3f6ea..f5c1c1aee0f3b7c348b2f2899b7c3e85e5d68fa0 100644

--- a/build/config/gcc/gcc_version.gni

+++ b/build/config/gcc/gcc_version.gni

@@ -9,8 +9,8 @@ if (is_android) {

} else {

gcc_version = 49

}

-} else if (current_toolchain == "//build/toolchain/cros:target") {

- # TODO(benchan): Generalize the check for platforms other than Chrome OS.

+} else if (current_toolchain == "//build/toolchain/cros:target" ||

+ current_toolchain == "//build/toolchain/linux:mipsel") {

gcc_version = exec_script("../../compiler_version.py",

[

"target",

« no previous file with comments | « no previous file | no next file » | no next file with comments »