Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 797593002: Fix gcc_version.gni to determine target GCC version for MIPSEL Linux. (Closed)

Created:
6 years ago by gordanac
Modified:
6 years ago
Reviewers:
brettw, Ben Chan, gordanac
CC:
chromium-reviews, cc-bugs_chromium.org, petar.jovanovic, Paul Lind, petarj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix gcc_version.gni to determine target GCC version for MIPSEL Linux. This CL modifies gcc_version.gni to set the gcc_version to the target GCC toolchain version when building for MIPSEL Linux. BUG= TEST=Compile 'chrome' target with 'os="linux" cpu_arch="mipsel"'. Manually verify that the correct GCC options are used. Committed: https://crrev.com/3bb044b814399b1584b8bcdedd8e2ffdb102b17d Cr-Commit-Position: refs/heads/master@{#308334}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment: Removed TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/config/gcc/gcc_version.gni View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
gordanac
Please take a look.
6 years ago (2014-12-11 13:20:41 UTC) #2
Ben Chan
On 2014/12/11 13:20:41, gordanac wrote: > Please take a look. I'm not the owner. +brettw ...
6 years ago (2014-12-11 14:59:05 UTC) #4
brettw
https://codereview.chromium.org/797593002/diff/1/build/config/gcc/gcc_version.gni File build/config/gcc/gcc_version.gni (right): https://codereview.chromium.org/797593002/diff/1/build/config/gcc/gcc_version.gni#newcode14 build/config/gcc/gcc_version.gni:14: # TODO(benchan): Generalize the check for platforms other than ...
6 years ago (2014-12-12 21:53:05 UTC) #5
brettw
LGTM with that change
6 years ago (2014-12-12 21:53:14 UTC) #6
gordanac
https://codereview.chromium.org/797593002/diff/1/build/config/gcc/gcc_version.gni File build/config/gcc/gcc_version.gni (right): https://codereview.chromium.org/797593002/diff/1/build/config/gcc/gcc_version.gni#newcode14 build/config/gcc/gcc_version.gni:14: # TODO(benchan): Generalize the check for platforms other than ...
6 years ago (2014-12-15 09:50:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797593002/20001
6 years ago (2014-12-15 09:51:03 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-15 10:32:40 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-15 10:33:16 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3bb044b814399b1584b8bcdedd8e2ffdb102b17d
Cr-Commit-Position: refs/heads/master@{#308334}

Powered by Google App Engine
This is Rietveld 408576698