Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Unified Diff: build/standalone.gypi

Issue 797583004: Temporarily remove warning about inconsistent overrides (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/standalone.gypi
diff --git a/build/standalone.gypi b/build/standalone.gypi
index 76fa7191eb54954e48ccd7439236cf0b94257d6c..bdb538d26c6755761ba66167e9ded5701208fc97 100644
--- a/build/standalone.gypi
+++ b/build/standalone.gypi
@@ -232,6 +232,13 @@
],
},
}],
+ ['clang==1', {
+ 'target_defaults': {
+ # Remove once issue 3753 is fixed.
+ 'cflags_cc': [ '-Wno-inconsistent-missing-override',
+ '-Wno-unknown-warning-option' ],
+ },
+ }],
['OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="solaris" \
or OS=="netbsd"', {
'target_defaults': {
@@ -247,7 +254,7 @@
# Don't warn about the "struct foo f = {0};" initialization pattern.
'-Wno-missing-field-initializers',
],
- 'cflags_cc': [ '-Wnon-virtual-dtor', '-fno-rtti', '-std=gnu++0x' ],
+ 'cflags_cc': [ '-Wnon-virtual-dtor', '-fno-rtti', '-std=gnu++0x', '-Wnoinconsistent-missing-override' ],
Michael Achenbach 2014/12/11 18:26:39 Guess this part ends up at the gcc command-line an
'ldflags': [ '-pthread', ],
'conditions': [
[ 'visibility=="hidden" and v8_enable_backtrace==0', {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698