Issue 797583004: Temporarily remove warning about inconsistent overrides

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 797583004: Temporarily remove warning about inconsistent overrides (Closed)

Created:
6 years ago by jochen (gone - plz use gerrit)

Modified:
6 years ago

Reviewers:
Michael Achenbach

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Temporarily remove warning about inconsistent overrides Otherwise, V8 won't compile with the latest clang anymore BUG=v8:3753 R=machenbach@chromium.org LOG=n

Patch Set 2 : updates #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	build/standalone.gypi	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Michael Achenbach

https://codereview.chromium.org/797583004/diff/1/build/standalone.gypi File build/standalone.gypi (right): https://codereview.chromium.org/797583004/diff/1/build/standalone.gypi#newcode257 build/standalone.gypi:257: 'cflags_cc': [ '-Wnon-virtual-dtor', '-fno-rtti', '-std=gnu++0x', '-Wnoinconsistent-missing-override' ], Guess this ...

6 years ago (2014-12-11 18:26:39 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797583004/20001

6 years ago (2014-12-11 18:43:45 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 797583004: Temporarily remove warning about inconsistent overrides (Closed)

Description

Patch Set 1 #

Patch Set 2 : updates #

Messages