Add externs for gallery.

Add externs for gallery.

BUG=433728
TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/gallery/js/compiled_resources.gyp && ninja -C out/Default

Committed: https://crrev.com/4e1fa4a8270c2180ce929db07991cc3f69e4a4d6
Cr-Commit-Position: refs/heads/master@{#309395}

[yawano, 2014-12-22 01:16:23]

yawano@chromium.org changed reviewers:
+ fukino@chromium.org

[yawano, 2014-12-22 01:16:24]

PTAL. Thank you!

[fukino, 2014-12-22 03:30:10]

https://codereview.chromium.org/797553004/diff/20001/ui/file_manager/externs/...
File ui/file_manager/externs/common.js (right):

https://codereview.chromium.org/797553004/diff/20001/ui/file_manager/externs/...
ui/file_manager/externs/common.js:5: // Externs which are common for all
applications under ui/file_manager.
Could you divide externs file which defines properties for each window? For
example, file_manager_foreground.js?

https://codereview.chromium.org/797553004/diff/20001/ui/file_manager/externs/...
File ui/file_manager/externs/gallery_foreground.js (right):

https://codereview.chromium.org/797553004/diff/20001/ui/file_manager/externs/...
ui/file_manager/externs/gallery_foreground.js:27: function FileManager() {}
It looks unclear that this definition is required by util.readFileBytes. Please
read byte_reader.js or move util.readFileBytes under file_manager/js/metadata

[yawano, 2014-12-22 04:04:41]

Thank you for the review. Since common file can become large easily, removed
externs/common.js and put them in extern of each application. PTAL.

https://codereview.chromium.org/797553004/diff/20001/ui/file_manager/externs/...
File ui/file_manager/externs/common.js (right):

https://codereview.chromium.org/797553004/diff/20001/ui/file_manager/externs/...
ui/file_manager/externs/common.js:5: // Externs which are common for all
applications under ui/file_manager.
On 2014/12/22 03:30:09, fukino wrote:
> Could you divide externs file which defines properties for each window? For
> example, file_manager_foreground.js?

Done. Removed externs/common.js.

https://codereview.chromium.org/797553004/diff/20001/ui/file_manager/externs/...
File ui/file_manager/externs/gallery_foreground.js (right):

https://codereview.chromium.org/797553004/diff/20001/ui/file_manager/externs/...
ui/file_manager/externs/gallery_foreground.js:27: function FileManager() {}
On 2014/12/22 03:30:10, fukino wrote:
> It looks unclear that this definition is required by util.readFileBytes.
Please
> read byte_reader.js or move util.readFileBytes under file_manager/js/metadata

Done. This definition is required by file_manager_dialog_base.js. Added a
comment about it.

[fukino, 2014-12-22 04:09:11]

On 2014/12/22 04:04:41, yawano wrote:
> Thank you for the review. Since common file can become large easily, removed
> externs/common.js and put them in extern of each application. PTAL.
> 
>
https://codereview.chromium.org/797553004/diff/20001/ui/file_manager/externs/...
> File ui/file_manager/externs/common.js (right):
> 
>
https://codereview.chromium.org/797553004/diff/20001/ui/file_manager/externs/...
> ui/file_manager/externs/common.js:5: // Externs which are common for all
> applications under ui/file_manager.
> On 2014/12/22 03:30:09, fukino wrote:
> > Could you divide externs file which defines properties for each window? For
> > example, file_manager_foreground.js?
> 
> Done. Removed externs/common.js.
> 
>
https://codereview.chromium.org/797553004/diff/20001/ui/file_manager/externs/...
> File ui/file_manager/externs/gallery_foreground.js (right):
> 
>
https://codereview.chromium.org/797553004/diff/20001/ui/file_manager/externs/...
> ui/file_manager/externs/gallery_foreground.js:27: function FileManager() {}
> On 2014/12/22 03:30:10, fukino wrote:
> > It looks unclear that this definition is required by util.readFileBytes.
> Please
> > read byte_reader.js or move util.readFileBytes under
file_manager/js/metadata
> 
> Done. This definition is required by file_manager_dialog_base.js. Added a
> comment about it.

lgtm

[yawano, 2014-12-22 04:09:42]

On 2014/12/22 04:09:11, fukino wrote:
> On 2014/12/22 04:04:41, yawano wrote:
> > Thank you for the review. Since common file can become large easily, removed
> > externs/common.js and put them in extern of each application. PTAL.
> > 
> >
>
https://codereview.chromium.org/797553004/diff/20001/ui/file_manager/externs/...
> > File ui/file_manager/externs/common.js (right):
> > 
> >
>
https://codereview.chromium.org/797553004/diff/20001/ui/file_manager/externs/...
> > ui/file_manager/externs/common.js:5: // Externs which are common for all
> > applications under ui/file_manager.
> > On 2014/12/22 03:30:09, fukino wrote:
> > > Could you divide externs file which defines properties for each window?
For
> > > example, file_manager_foreground.js?
> > 
> > Done. Removed externs/common.js.
> > 
> >
>
https://codereview.chromium.org/797553004/diff/20001/ui/file_manager/externs/...
> > File ui/file_manager/externs/gallery_foreground.js (right):
> > 
> >
>
https://codereview.chromium.org/797553004/diff/20001/ui/file_manager/externs/...
> > ui/file_manager/externs/gallery_foreground.js:27: function FileManager() {}
> > On 2014/12/22 03:30:10, fukino wrote:
> > > It looks unclear that this definition is required by util.readFileBytes.
> > Please
> > > read byte_reader.js or move util.readFileBytes under
> file_manager/js/metadata
> > 
> > Done. This definition is required by file_manager_dialog_base.js. Added a
> > comment about it.
> 
> lgtm

Thank you!

[yawano, 2014-12-22 04:09:45]

The CQ bit was checked by yawano@chromium.org

[commit-bot: I haz the power, 2014-12-22 04:09:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/797553004/40001

[commit-bot: I haz the power, 2014-12-22 05:01:35]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-12-22 05:02:30]

Patchset 3 (id:??) landed as
https://crrev.com/4e1fa4a8270c2180ce929db07991cc3f69e4a4d6
Cr-Commit-Position: refs/heads/master@{#309395}