Allow to add assets to test apks

Allow to add assets to test apks

R=cjhopman@chromium.org

Committed: https://crrev.com/9bdb24aa8d920e57b81341a912dc18a7d24be5df
Cr-Commit-Position: refs/heads/master@{#309414}

[qsr, 2014-12-19 15:24:38]

This is needed for some tests in mojo that need some additional data. This will
also be needed to net unittests when those are converted to gn.

[cjhopman, 2014-12-19 19:13:18]

On 2014/12/19 15:24:38, qsr wrote:
> This is needed for some tests in mojo that need some additional data. This
will
> also be needed to net unittests when those are converted to gn.

In chromium, we typically don't put test data and other assets into unittest
apks. Instead we push that data to a shared location on the device so that we
don't end up having to push the same data many times (the unittests also change
paths around so that even if you do package assets, they may not find them
because they are looking in the shared location).

That being said, I think supporting this is probably fine. lgtm.

[qsr, 2014-12-22 09:53:51]

On 2014/12/19 19:13:18, cjhopman wrote:
> On 2014/12/19 15:24:38, qsr wrote:
> > This is needed for some tests in mojo that need some additional data. This
> will
> > also be needed to net unittests when those are converted to gn.
> 
> In chromium, we typically don't put test data and other assets into unittest
> apks. Instead we push that data to a shared location on the device so that we
> don't end up having to push the same data many times (the unittests also
change
> paths around so that even if you do package assets, they may not find them
> because they are looking in the shared location).

 Hum, if I look at net.gyp, net_unittests_apk use asset_location

 Also, while test_runner.py instrumentation does have a test_data option, I
don't see it for test_runner.py gtest.

 Could you point me to some place where we do use external data for gtest tests?

> That being said, I think supporting this is probably fine. lgtm.

[qsr, 2014-12-22 09:54:33]

The CQ bit was checked by qsr@chromium.org

[commit-bot: I haz the power, 2014-12-22 09:54:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/797503003/1

[commit-bot: I haz the power, 2014-12-22 10:38:05]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-12-22 10:39:00]

Patchset 1 (id:??) landed as
https://crrev.com/9bdb24aa8d920e57b81341a912dc18a7d24be5df
Cr-Commit-Position: refs/heads/master@{#309414}

[cjhopman, 2014-12-22 19:15:48]

On 2014/12/22 10:39:00, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/9bdb24aa8d920e57b81341a912dc18a7d24be5df
> Cr-Commit-Position: refs/heads/master@{#309414}

When running unittest suites, isolate files are found with this mapping:
https://code.google.com/p/chromium/codesearch#chromium/src/build/android/pyli...

The data listed in the isolate file is copied to the device.

[cjhopman, 2014-12-22 19:19:53]

On 2014/12/22 19:15:48, cjhopman wrote:
> On 2014/12/22 10:39:00, I haz the power (commit-bot) wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/9bdb24aa8d920e57b81341a912dc18a7d24be5df
> > Cr-Commit-Position: refs/heads/master@{#309414}
> 
> When running unittest suites, isolate files are found with this mapping:
>
https://code.google.com/p/chromium/codesearch#chromium/src/build/android/pyli...
> 
> The data listed in the isolate file is copied to the device.

Oh right, and while net_unittests does have such an isolate file, it also has
the v8 thing in its assets. With the current way things are done in gyp, there
wasn't a good way for us to have conditions in the isolate (the v8 stuff is only
needed in certain configurations), and so a lot of the targets will have the v8
stuff in assets. I think we can do that in a better way in GN, but it'll
probably be easier for us to stay the same as gyp during the transition anyway.

[qsr, 2014-12-23 09:22:18]

> When running unittest suites, isolate files are found with this mapping:
>
https://code.google.com/p/chromium/codesearch#chromium/src/build/android/pyli...
> 
> The data listed in the isolate file is copied to the device.


 Do we have isolate support in the gn build? git grep didn't show me anything.

[cjhopman, 2014-12-23 19:55:12]

On 2014/12/23 09:22:18, qsr wrote:
> > When running unittest suites, isolate files are found with this mapping:
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/build/android/pyli...
> > 
> > The data listed in the isolate file is copied to the device.
> 
> 
>  Do we have isolate support in the gn build? git grep didn't show me anything.

I don't think so. I expect we will probably use the 'data' (and maybe
'datadeps') target argument for it, but afaik there isn't really anything done
yet.