Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1439)

Issue 797483004: Partially reapply "Isolate remaining tests under ui/" (Closed)

Created:
6 years ago by M-A Ruel
Modified:
6 years ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tdresser+watch_chromium.org, tfarina, mlamouri+watch-notifications_chromium.org, peter+watch_chromium.org, jdduke+watch_chromium.org, sky
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Partially reapply "Isolate remaining tests under ui/" The initial commit was in 42f9c67b74. The difference is: - Left out testing/buildbot/chromium.win.json since it caused http://crbug.com/441690 and more investigation is needed. TBR=jochen@chromium.org R=jam@chromium.org BUG=98637 Committed: https://crrev.com/c72391a16daa1234633a1caf7e76896e243d20d7 Cr-Commit-Position: refs/heads/master@{#308167}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+515 lines, -125 lines) Patch
M testing/buildbot/chromium.linux.json View 9 chunks +90 lines, -15 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 16 chunks +120 lines, -20 lines 0 comments Download
M testing/buildbot/chromium_trybot.json View 4 chunks +36 lines, -6 lines 0 comments Download
M ui/accessibility/accessibility.gyp View 1 chunk +26 lines, -0 lines 0 comments Download
A + ui/accessibility/accessibility_unittests.isolate View 2 chunks +6 lines, -4 lines 0 comments Download
M ui/app_list/app_list.gyp View 1 chunk +24 lines, -0 lines 0 comments Download
A + ui/app_list/app_list_unittests.isolate View 3 chunks +21 lines, -20 lines 0 comments Download
M ui/base/ui_base_tests.gyp View 1 chunk +24 lines, -0 lines 0 comments Download
A + ui/base/ui_base_unittests.isolate View 3 chunks +31 lines, -20 lines 0 comments Download
M ui/events/events.gyp View 1 chunk +24 lines, -0 lines 0 comments Download
A + ui/events/events_unittests.isolate View 3 chunks +20 lines, -20 lines 0 comments Download
M ui/gfx/gfx_tests.gyp View 1 chunk +24 lines, -0 lines 0 comments Download
A ui/gfx/gfx_unittests.isolate View 1 chunk +22 lines, -0 lines 0 comments Download
M ui/message_center/message_center.gyp View 1 chunk +26 lines, -0 lines 0 comments Download
A + ui/message_center/message_center_unittests.isolate View 3 chunks +21 lines, -20 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
M-A Ruel
6 years ago (2014-12-12 15:23:04 UTC) #1
M-A Ruel
I forgot to note, I prefer to have the code committed and used on linux ...
6 years ago (2014-12-12 15:24:02 UTC) #2
tfarina
Marc-Antoine, would you mind including in the CL description the command lines you used to ...
6 years ago (2014-12-12 15:25:41 UTC) #3
M-A Ruel
On 2014/12/12 15:25:41, tfarina wrote: > Marc-Antoine, would you mind including in the CL description ...
6 years ago (2014-12-12 15:31:22 UTC) #4
jam
lgtm
6 years ago (2014-12-12 16:59:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797483004/1
6 years ago (2014-12-12 19:48:59 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 21:39:47 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-12 21:40:48 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c72391a16daa1234633a1caf7e76896e243d20d7
Cr-Commit-Position: refs/heads/master@{#308167}

Powered by Google App Engine
This is Rietveld 408576698