Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: pkg/args/test/command_test.dart

Issue 797473002: Add a CommandRunner class for dispatching commands to args. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/args/test/command_test.dart
diff --git a/pkg/args/test/command_test.dart b/pkg/args/test/command_test.dart
index 1380e160087914b36198eb1a5cbdef90caea531b..ae3594b114a54240b798a601cf462d6ec7f52538 100644
--- a/pkg/args/test/command_test.dart
+++ b/pkg/args/test/command_test.dart
@@ -1,207 +1,110 @@
-// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
+// Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
library command_test;
-import 'package:unittest/unittest.dart';
import 'package:args/args.dart';
+import 'package:args/command_runner.dart';
+import 'package:unittest/unittest.dart';
import 'utils.dart';
void main() {
- group('ArgParser.addCommand()', () {
- test('creates a new ArgParser if none is given', () {
- var parser = new ArgParser();
- var command = parser.addCommand('install');
- expect(parser.commands['install'], equals(command));
- expect(command is ArgParser, isTrue);
- });
+ var foo;
+ setUp(() {
+ foo = new FooCommand();
- test('uses the command parser if given one', () {
- var parser = new ArgParser();
- var command = new ArgParser();
- var result = parser.addCommand('install', command);
- expect(parser.commands['install'], equals(command));
- expect(result, equals(command));
- });
-
- test('throws on a duplicate command name', () {
- var parser = new ArgParser();
- parser.addCommand('install');
- throwsIllegalArg(() => parser.addCommand('install'));
- });
+ // Make sure [Command.runner] is set up.
+ new CommandRunner("test", "A test command runner.").addCommand(foo);
});
- group('ArgParser.parse()', () {
- test('parses a command', () {
- var parser = new ArgParser();
- var command = parser.addCommand('install');
-
- var args = parser.parse(['install']);
-
- expect(args.command.name, equals('install'));
- expect(args.rest, isEmpty);
+ group(".invocation has a sane default", () {
+ test("without subcommands", () {
+ expect(foo.invocation,
+ equals("test foo [arguments]"));
});
- test('parses a command option', () {
- var parser = new ArgParser();
- var command = parser.addCommand('install');
- command.addOption('path');
-
- var args = parser.parse(['install', '--path', 'some/path']);
- expect(args.command['path'], equals('some/path'));
+ test("with subcommands", () {
+ foo.addSubcommand(new AsyncCommand());
+ expect(foo.invocation,
+ equals("test foo <subcommand> [arguments]"));
});
- test('parses a parent solo option before the command', () {
- var parser = new ArgParser();
- parser.addOption('mode', abbr: 'm');
- var command = parser.addCommand('install');
+ test("for a subcommand", () {
+ var async = new AsyncCommand();
+ foo.addSubcommand(async);
- var args = parser.parse(['-m', 'debug', 'install']);
- expect(args['mode'], equals('debug'));
- expect(args.command.name, equals('install'));
+ expect(async.invocation,
+ equals("test foo async [arguments]"));
});
+ });
- test('parses a parent solo option after the command', () {
- var parser = new ArgParser();
- parser.addOption('mode', abbr: 'm');
- var command = parser.addCommand('install');
-
- var args = parser.parse(['install', '-m', 'debug']);
- expect(args['mode'], equals('debug'));
- expect(args.command.name, equals('install'));
- });
+ group(".usage", () {
+ test("returns the usage string", () {
+ expect(foo.usage, equals("""
+Set a value.
- test('parses a parent option before the command', () {
- var parser = new ArgParser();
- parser.addFlag('verbose');
- var command = parser.addCommand('install');
+Usage: test foo [arguments]
+-h, --help Print this usage information.
- var args = parser.parse(['--verbose', 'install']);
- expect(args['verbose'], isTrue);
- expect(args.command.name, equals('install'));
+Run "test help" to see global options."""));
});
- test('parses a parent option after the command', () {
- var parser = new ArgParser();
- parser.addFlag('verbose');
- var command = parser.addCommand('install');
+ test("contains custom options", () {
+ foo.argParser.addFlag("flag", help: "Do something.");
- var args = parser.parse(['install', '--verbose']);
- expect(args['verbose'], isTrue);
- expect(args.command.name, equals('install'));
- });
+ expect(foo.usage, equals("""
+Set a value.
- test('parses a parent negated option before the command', () {
- var parser = new ArgParser();
- parser.addFlag('verbose', defaultsTo: true);
- var command = parser.addCommand('install');
+Usage: test foo [arguments]
+-h, --help Print this usage information.
+ --[no-]flag Do something.
- var args = parser.parse(['--no-verbose', 'install']);
- expect(args['verbose'], isFalse);
- expect(args.command.name, equals('install'));
+Run "test help" to see global options."""));
});
- test('parses a parent negated option after the command', () {
- var parser = new ArgParser();
- parser.addFlag('verbose', defaultsTo: true);
- var command = parser.addCommand('install');
-
- var args = parser.parse(['install', '--no-verbose']);
- expect(args['verbose'], isFalse);
- expect(args.command.name, equals('install'));
- });
+ test("doesn't print hidden subcommands", () {
+ foo.addSubcommand(new AsyncCommand());
+ foo.addSubcommand(new HiddenCommand());
- test('parses a parent abbreviation before the command', () {
- var parser = new ArgParser();
- parser.addFlag('debug', abbr: 'd');
- parser.addFlag('verbose', abbr: 'v');
- var command = parser.addCommand('install');
+ expect(foo.usage, equals("""
+Set a value.
- var args = parser.parse(['-dv', 'install']);
- expect(args['debug'], isTrue);
- expect(args['verbose'], isTrue);
- expect(args.command.name, equals('install'));
- });
+Usage: test foo <subcommand> [arguments]
+-h, --help Print this usage information.
- test('parses a parent abbreviation after the command', () {
- var parser = new ArgParser();
- parser.addFlag('debug', abbr: 'd');
- parser.addFlag('verbose', abbr: 'v');
- var command = parser.addCommand('install');
+Available subcommands:
+ async Set a value asynchronously.
- var args = parser.parse(['install', '-dv']);
- expect(args['debug'], isTrue);
- expect(args['verbose'], isTrue);
- expect(args.command.name, equals('install'));
+Run "test help" to see global options."""));
});
- test('does not parse a solo command option before the command', () {
- var parser = new ArgParser();
- var command = parser.addCommand('install');
- command.addOption('path', abbr: 'p');
-
- throwsFormat(parser, ['-p', 'foo', 'install']);
- });
+ test("doesn't print subcommand aliases", () {
+ foo.addSubcommand(new AliasedCommand());
- test('does not parse a command option before the command', () {
- var parser = new ArgParser();
- var command = parser.addCommand('install');
- command.addOption('path');
+ expect(foo.usage, equals("""
+Set a value.
- throwsFormat(parser, ['--path', 'foo', 'install']);
- });
+Usage: test foo <subcommand> [arguments]
+-h, --help Print this usage information.
- test('does not parse a command abbreviation before the command', () {
- var parser = new ArgParser();
- var command = parser.addCommand('install');
- command.addFlag('debug', abbr: 'd');
- command.addFlag('verbose', abbr: 'v');
+Available subcommands:
+ aliased Set a value.
- throwsFormat(parser, ['-dv', 'install']);
+Run "test help" to see global options."""));
});
+ });
- test('assigns collapsed options to the proper command', () {
- var parser = new ArgParser();
- parser.addFlag('apple', abbr: 'a');
- var command = parser.addCommand('cmd');
- command.addFlag('banana', abbr: 'b');
- var subcommand = command.addCommand('subcmd');
- subcommand.addFlag('cherry', abbr: 'c');
-
- var args = parser.parse(['cmd', 'subcmd', '-abc']);
- expect(args['apple'], isTrue);
- expect(args.command.name, equals('cmd'));
- expect(args.command['banana'], isTrue);
- expect(args.command.command.name, equals('subcmd'));
- expect(args.command.command['cherry'], isTrue);
- });
+ test("usageException splits up the message and usage", () {
+ expect(() => foo.usageException("message"), throwsUsageError("message", """
+Usage: test foo [arguments]
+-h, --help Print this usage information.
- test('option is given to innermost command that can take it', () {
- var parser = new ArgParser();
- parser.addFlag('verbose');
- var command = parser.addCommand('cmd');
- command.addFlag('verbose');
- var subcommand = command.addCommand('subcmd');
-
- var args = parser.parse(['cmd', 'subcmd', '--verbose']);
- expect(args['verbose'], isFalse);
- expect(args.command.name, equals('cmd'));
- expect(args.command['verbose'], isTrue);
- expect(args.command.command.name, equals('subcmd'));
- });
+Run "test help" to see global options."""));
+ });
- test('remaining arguments are given to the innermost command', () {
- var parser = new ArgParser();
- var command = parser.addCommand('cmd');
- var subcommand = command.addCommand('subcmd');
-
- var args = parser.parse(['cmd', 'subcmd', 'other', 'stuff']);
- expect(args.command.name, equals('cmd'));
- expect(args.rest, isEmpty);
- expect(args.command.command.name, equals('subcmd'));
- expect(args.command.rest, isEmpty);
- expect(args.command.command.rest, equals(['other', 'stuff']));
- });
+ test("considers a command hidden if all its subcommands are hidden", () {
+ foo.addSubcommand(new HiddenCommand());
+ expect(foo.hidden, isTrue);
});
}

Powered by Google App Engine
This is Rietveld 408576698