Source/core/page/SpatialNavigation.h - Issue 797463003: spatnav: Allow focus move to a close-by not-fully-aligned node over a distant but fully-aligned nod…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/SpatialNavigation.h

Issue 797463003: spatnav: Allow focus move to a close-by not-fully-aligned node over a distant but fully-aligned nod… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fix not-aligned node issue Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/SpatialNavigation.h

diff --git a/Source/core/page/SpatialNavigation.h b/Source/core/page/SpatialNavigation.h

index c4a5cfb46bce776ced83383ade66fd175b5e0d86..9290805947710c2e6e7eba267b86f45176713d7d 100644

--- a/Source/core/page/SpatialNavigation.h

+++ b/Source/core/page/SpatialNavigation.h

@@ -102,7 +102,6 @@ public:

, focusableNode(nullptr)

, enclosingScrollableBox(nullptr)

, distance(maxDistance())

- , alignment(None)

, isOffscreen(true)

, isOffscreenAfterScrolling(true)

{

@@ -122,7 +121,6 @@ public:

RawPtrWillBeMember<Node> focusableNode;

RawPtrWillBeMember<Node> enclosingScrollableBox;

double distance;

- RectsAlignment alignment;

LayoutRect rect;

bool isOffscreen;

bool isOffscreenAfterScrolling;

« no previous file with comments | « Source/core/page/FocusController.cpp ('k') | Source/core/page/SpatialNavigation.cpp » ('j') | Source/core/page/SpatialNavigation.cpp » ('J')