Source/core/page/FocusController.cpp - Issue 797463003: spatnav: Allow focus move to a close-by not-fully-aligned node over a distant but fully-aligned nod…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/FocusController.cpp

Issue 797463003: spatnav: Allow focus move to a close-by not-fully-aligned node over a distant but fully-aligned nod… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebaseline Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/spatial-navigation/snav-symmetrically-positioned-expected.txt ('k') | Source/core/page/SpatialNavigation.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/page/FocusController.cpp

diff --git a/Source/core/page/FocusController.cpp b/Source/core/page/FocusController.cpp

index 0ea5a98141a4fdb3da523a3ca54ed4379581b690..53316878caceef119d0dc94a8414715762765176 100644

--- a/Source/core/page/FocusController.cpp

+++ b/Source/core/page/FocusController.cpp

@@ -769,7 +769,7 @@ static void updateFocusCandidateIfNeeded(WebFocusType type, const FocusCandidate

if (candidate.distance == maxDistance())

return;

- if (candidate.isOffscreenAfterScrolling && candidate.alignment < Full)

+ if (candidate.isOffscreenAfterScrolling)

return;

if (closest.isNull()) {

@@ -794,13 +794,7 @@ static void updateFocusCandidateIfNeeded(WebFocusType type, const FocusCandidate

return;

}

- if (candidate.alignment == closest.alignment) {

- if (candidate.distance < closest.distance)

- closest = candidate;

- return;

- }

- if (candidate.alignment > closest.alignment)

+ if (candidate.distance < closest.distance)

closest = candidate;

}