Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4955)

Unified Diff: chrome/browser/prerender/prerender_contents.cc

Issue 797443002: Remove prerender sessionStorage namespace merging (1/2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prerender/prerender_contents.h ('k') | chrome/browser/prerender/prerender_events.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_contents.cc
diff --git a/chrome/browser/prerender/prerender_contents.cc b/chrome/browser/prerender/prerender_contents.cc
index d225d9c9ca681a4058a36d8e81fc9ce97f313f12..5d5a5cca833660b3c598dab5aee5f773cef31421 100644
--- a/chrome/browser/prerender/prerender_contents.cc
+++ b/chrome/browser/prerender/prerender_contents.cc
@@ -322,9 +322,7 @@ void PrerenderContents::StartPrerendering(
prerendering_has_started_ = true;
- alias_session_storage_namespace = session_storage_namespace->CreateAlias();
- prerender_contents_.reset(
- CreateWebContents(alias_session_storage_namespace.get()));
+ prerender_contents_.reset(CreateWebContents(session_storage_namespace));
TabHelpers::AttachTabHelpers(prerender_contents_.get());
content::WebContentsObserver::Observe(prerender_contents_.get());
@@ -336,10 +334,6 @@ void PrerenderContents::StartPrerendering(
child_id_ = GetRenderViewHost()->GetProcess()->GetID();
route_id_ = GetRenderViewHost()->GetRoutingID();
- // Log transactions to see if we could merge session storage namespaces in
- // the event of a mismatch.
- alias_session_storage_namespace->AddTransactionLogProcessId(child_id_);
-
// Add the RenderProcessHost to the Prerender Manager.
prerender_manager()->AddPrerenderProcessHost(
GetRenderViewHost()->GetProcess());
@@ -588,6 +582,8 @@ bool PrerenderContents::AddAliasURL(const GURL& url) {
bool PrerenderContents::Matches(
const GURL& url,
const SessionStorageNamespace* session_storage_namespace) const {
+ // TODO(davidben): Remove any consumers that pass in a NULL
+ // session_storage_namespace and only test with matches.
if (session_storage_namespace &&
session_storage_namespace_id_ != session_storage_namespace->id()) {
return false;
@@ -746,8 +742,6 @@ void PrerenderContents::DestroyWhenUsingTooManyResources() {
WebContents* PrerenderContents::ReleasePrerenderContents() {
prerender_contents_->SetDelegate(NULL);
content::WebContentsObserver::Observe(NULL);
- if (alias_session_storage_namespace.get())
- alias_session_storage_namespace->RemoveTransactionLogProcessId(child_id_);
return prerender_contents_.release();
}
@@ -809,13 +803,6 @@ void PrerenderContents::PrepareForUse() {
resource_throttles_.clear();
}
-SessionStorageNamespace* PrerenderContents::GetSessionStorageNamespace() const {
- if (!prerender_contents())
- return NULL;
- return prerender_contents()->GetController().
- GetDefaultSessionStorageNamespace();
-}
-
void PrerenderContents::OnCancelPrerenderForPrinting() {
Destroy(FINAL_STATUS_WINDOW_PRINT);
}
« no previous file with comments | « chrome/browser/prerender/prerender_contents.h ('k') | chrome/browser/prerender/prerender_events.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698