Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: chrome/browser/prerender/prerender_contents.cc

Issue 797443002: Remove prerender sessionStorage namespace merging (1/2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_contents.cc
diff --git a/chrome/browser/prerender/prerender_contents.cc b/chrome/browser/prerender/prerender_contents.cc
index 5110ba771d177ade2713a950d3d0f6da54a4bfcb..f9a59dc5dded43d6a6675f21d94cd85c24404710 100644
--- a/chrome/browser/prerender/prerender_contents.cc
+++ b/chrome/browser/prerender/prerender_contents.cc
@@ -321,9 +321,7 @@ void PrerenderContents::StartPrerendering(
prerendering_has_started_ = true;
- alias_session_storage_namespace = session_storage_namespace->CreateAlias();
- prerender_contents_.reset(
- CreateWebContents(alias_session_storage_namespace.get()));
+ prerender_contents_.reset(CreateWebContents(session_storage_namespace));
TabHelpers::AttachTabHelpers(prerender_contents_.get());
content::WebContentsObserver::Observe(prerender_contents_.get());
@@ -335,10 +333,6 @@ void PrerenderContents::StartPrerendering(
child_id_ = GetRenderViewHost()->GetProcess()->GetID();
route_id_ = GetRenderViewHost()->GetRoutingID();
- // Log transactions to see if we could merge session storage namespaces in
- // the event of a mismatch.
- alias_session_storage_namespace->AddTransactionLogProcessId(child_id_);
-
// Add the RenderProcessHost to the Prerender Manager.
prerender_manager()->AddPrerenderProcessHost(
GetRenderViewHost()->GetProcess());
@@ -745,8 +739,6 @@ void PrerenderContents::DestroyWhenUsingTooManyResources() {
WebContents* PrerenderContents::ReleasePrerenderContents() {
prerender_contents_->SetDelegate(NULL);
content::WebContentsObserver::Observe(NULL);
- if (alias_session_storage_namespace.get())
- alias_session_storage_namespace->RemoveTransactionLogProcessId(child_id_);
return prerender_contents_.release();
}
@@ -808,13 +800,6 @@ void PrerenderContents::PrepareForUse() {
resource_throttles_.clear();
}
-SessionStorageNamespace* PrerenderContents::GetSessionStorageNamespace() const {
- if (!prerender_contents())
- return NULL;
- return prerender_contents()->GetController().
- GetDefaultSessionStorageNamespace();
-}
-
void PrerenderContents::OnCancelPrerenderForPrinting() {
Destroy(FINAL_STATUS_WINDOW_PRINT);
}

Powered by Google App Engine
This is Rietveld 408576698