Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 797413002: MacViews: Compile more Views source files. (Closed)

Created:
6 years ago by Andre
Modified:
6 years ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, mac-views-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Compile more Views source files. A collection of small fixes towards getting MacViews browser to build, including: * Modal dialogs expect a NativeView parent. * Add BrowserNonClientFrameViewFactoryMac. * Keyboard component not available without Aura. BUG=425229 Committed: https://crrev.com/ba3ef5d7974dfe82bfa9b8894d16ebf26d678ad6 Cr-Commit-Position: refs/heads/master@{#308406}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix for sky and rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -44 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/app/nibs/ExtensionInstalledBubble.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_dialog_cloud.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud_internal.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/browser_dialogs.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/web_dialog_window_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/chrome_web_dialog_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc View 1 chunk +0 lines, -4 lines 0 comments Download
A chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_mac.mm View 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view_platform_specific.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/hung_renderer_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/hung_renderer_view.cc View 4 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_view.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 7 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Andre
sky@ PTAL.
6 years ago (2014-12-13 01:38:18 UTC) #2
sky
LGTM https://codereview.chromium.org/797413002/diff/1/chrome/browser/ui/views/frame/taskbar_decorator.cc File chrome/browser/ui/views/frame/taskbar_decorator.cc (right): https://codereview.chromium.org/797413002/diff/1/chrome/browser/ui/views/frame/taskbar_decorator.cc#newcode9 chrome/browser/ui/views/frame/taskbar_decorator.cc:9: #if !defined(OS_WIN) How about conditionally compiling this file ...
6 years ago (2014-12-15 15:53:53 UTC) #3
Andre
https://codereview.chromium.org/797413002/diff/1/chrome/browser/ui/views/frame/taskbar_decorator.cc File chrome/browser/ui/views/frame/taskbar_decorator.cc (right): https://codereview.chromium.org/797413002/diff/1/chrome/browser/ui/views/frame/taskbar_decorator.cc#newcode9 chrome/browser/ui/views/frame/taskbar_decorator.cc:9: #if !defined(OS_WIN) On 2014/12/15 15:53:53, sky wrote: > How ...
6 years ago (2014-12-15 19:04:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797413002/20001
6 years ago (2014-12-15 20:18:27 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-15 20:30:37 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-15 20:31:28 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ba3ef5d7974dfe82bfa9b8894d16ebf26d678ad6
Cr-Commit-Position: refs/heads/master@{#308406}

Powered by Google App Engine
This is Rietveld 408576698