Chromium Code Reviews
Help | Chromium Project | Sign in
(5)

Issue 7974012: Speed up check_licenses by another 30% by scanning less files. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 11 months ago by Paweł Hajdan Jr.
Modified:
3 years, 11 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews
Visibility:
Public.

Description

Speed up check_licenses by another 30% by scanning less files. This improves run time from ~3 minutes to ~2 minutes for me locally. BUG=28291 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102363

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M third_party/devscripts/chromium-1.patch View 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/devscripts/licensecheck.pl View 1 chunk +6 lines, -0 lines 1 comment Download
Project "None" does not have a commit queue.

Messages

Total messages: 2 (0 generated)
Paweł Hajdan Jr.
3 years, 11 months ago (2011-09-22 20:52:38 UTC) #1
Evan Martin
3 years, 11 months ago (2011-09-22 20:54:12 UTC) #2
LGTM

http://codereview.chromium.org/7974012/diff/1/third_party/devscripts/licensec...
File third_party/devscripts/licensecheck.pl (right):

http://codereview.chromium.org/7974012/diff/1/third_party/devscripts/licensec...
third_party/devscripts/licensecheck.pl:245: push @find_args, qw(-not ( -path
*/out/Debug/* -prune ) );
*/out/* is probably better.  (In theory gyp can generate other configurations,
like a profiling one, that will get its own directory here)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c33a7a4