Break large blobs into multiple ipcs during creation.

webkit/blob/blob_data.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_BLOB_BLOB_DATA_H_
 #define WEBKIT_BLOB_BLOB_DATA_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 10 matching lines @@
 namespace webkit_blob {
 
 class BlobData : public base::RefCounted<BlobData> {
  public:
   enum Type {
     TYPE_DATA,
     TYPE_FILE,
     TYPE_BLOB
   };
 
-  class Item {
-   public:
+  struct Item {
     Item();
     ~Item();
 
     Type type() const { return type_; }
     const std::string& data() const { return data_; }
     const FilePath& file_path() const { return file_path_; }
     const GURL& blob_url() const { return blob_url_; }
     uint64 offset() const { return offset_; }
     uint64 length() const { return length_; }
     const base::Time& expected_modification_time() const {
       return expected_modification_time_;
     }
 
     void SetToData(const std::string& data) {
       SetToData(data, 0, static_cast<uint32>(data.size()));
     }
 
     void SetToData(const std::string& data, uint32 offset, uint32 length) {
       // TODO(jianli): Need to implement ref-counting vector storage.
       type_ = TYPE_DATA;
       data_ = data;
       offset_ = offset;
       length_ = length;
     }
 
+    void SetToData(const char* data, int length) {

[jianli, 2011/09/27 01:12:18]

Why not using uint32?

[michaeln, 2011/09/27 23:27:31]

Done, switched to using size_t which is what std::string expects.

+      type_ = TYPE_DATA;
+      data_.assign(data, length);
+      offset_ = 0;
+      length_ = length;
+    }
+
     void SetToFile(const FilePath& file_path, uint64 offset, uint64 length,
                    const base::Time& expected_modification_time) {
       type_ = TYPE_FILE;
       file_path_ = file_path;
       offset_ = offset;
       length_ = length;
       expected_modification_time_ = expected_modification_time;
     }
 
     void SetToBlob(const GURL& blob_url, uint64 offset, uint64 length) {
       type_ = TYPE_BLOB;
       blob_url_ = blob_url;
       offset_ = offset;
       length_ = length;
     }
 
-   private:
     Type type_;
 
     // For Data type.
     std::string data_;
 
     // For File type.
     FilePath file_path_;
 
     // For Blob typ.
     GURL blob_url_;
 
     uint64 offset_;
     uint64 length_;
     base::Time expected_modification_time_;
   };
 
   BlobData();
   explicit BlobData(const WebKit::WebBlobData& data);
 
+  void AppendItem(const Item& item) {
+    items_.push_back(item);
+  }
+
   void AppendData(const std::string& data) {
     // TODO(jianli): Consider writing the big data to the disk.
     AppendData(data, 0, static_cast<uint32>(data.size()));
   }
 
   void AppendData(const std::string& data, uint32 offset, uint32 length) {
     if (length > 0) {
       items_.push_back(Item());
       items_.back().SetToData(data, offset, length);
     }
@@ skipping 22 matching lines @@
     content_type_ = content_type;
   }
 
   const std::string& content_disposition() const {
     return content_disposition_;
   }
   void set_content_disposition(const std::string& content_disposition) {
     content_disposition_ = content_disposition;
   }
 
-  // Should only be called by the IPC ParamTraits for this class.
-  void swap_items(std::vector<Item>* items) {
-    items_.swap(*items);
+  int64 GetMemoryUsage() const {
+    int64 memory = 0;
+    for (std::vector<Item>::const_iterator iter = items_.begin();
+         iter != items_.end(); ++iter) {
+      if (iter->type() == TYPE_DATA)
+        memory += iter->data_.size();
+    }
+    return memory;
   }
 
  private:
   friend class base::RefCounted<BlobData>;
 
   virtual ~BlobData();
 
   std::string content_type_;
   std::string content_disposition_;
   std::vector<Item> items_;
@@ skipping 44 matching lines @@
 }
 
 inline bool operator!=(const BlobData& a, const BlobData& b) {
   return !(a == b);
 }
 #endif  // defined(UNIT_TEST)
 
 }  // namespace webkit_blob
 
 #endif  // WEBKIT_BLOB_BLOB_DATA_H_