Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 797393003: MacViews: Rename Cocoa files to avoid conflict with Views. (Closed)

Created:
6 years ago by Andre
Modified:
6 years ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, miu+watch_chromium.org, mac-views-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Rename Cocoa files to avoid conflict with Views. cocoa/media_indicator_button.* is renamed to media_indicator_button_cocoa.* to avoid conflict with views/media_indicator_button.* BUG=425229 Committed: https://crrev.com/8faa6b86fd6bdfaa9cb97999b8aaa6bb46df5d44 Cr-Commit-Position: refs/heads/master@{#308439}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -354 lines) Patch
D chrome/browser/ui/cocoa/tabs/media_indicator_button.h View 1 chunk +0 lines, -77 lines 0 comments Download
D chrome/browser/ui/cocoa/tabs/media_indicator_button.mm View 1 chunk +0 lines, -175 lines 0 comments Download
A + chrome/browser/ui/cocoa/tabs/media_indicator_button_cocoa.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/tabs/media_indicator_button_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/tabs/media_indicator_button_cocoa_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/cocoa/tabs/media_indicator_button_unittest.mm View 1 chunk +0 lines, -90 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_view.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Andre
Robert PTAL.
6 years ago (2014-12-14 23:40:41 UTC) #2
Robert Sesek
LGTM
6 years ago (2014-12-15 21:28:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797393003/1
6 years ago (2014-12-15 21:31:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-15 22:21:52 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-15 22:23:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8faa6b86fd6bdfaa9cb97999b8aaa6bb46df5d44
Cr-Commit-Position: refs/heads/master@{#308439}

Powered by Google App Engine
This is Rietveld 408576698