Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 797383002: Revert of Update DisplayConfigurator to use the asynchronous tasks (Closed)

Created:
6 years ago by samuong
Modified:
6 years ago
Reviewers:
dnicoara, Daniel Erat
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@async-refactor4
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update DisplayConfigurator to use the asynchronous tasks (patchset #4 id:60001 of https://codereview.chromium.org/801493002/) Reason for revert: seems to be causing problems in display_unittests on the following bot: https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/5095 Original issue's description: > Update DisplayConfigurator to use the asynchronous tasks > > Now DisplayConfigurator can take advantage of asynchronous configuration APIs. > Note: For X11, NativeDisplayDelegate is still implemented via synchronous calls > so all configurations will be synchronous on X11. > > Notable changes: > 1) EnterState(), UpdateCachedDisplays() and FindMirrorMode() have been moved > into the DisplayLayoutManager implementation. > 2) NativeDisplayDelegate's initialization has been moved before grabbing the > server. Shouldn't cause any issues since the server doesn't need to be grabbed > when initializing NDD. > > BUG=429746 > TEST=display_unittests and manually on Link with X11 > > Committed: https://crrev.com/7547705543d6b711a166e513a43a4e43f93fd254 > Cr-Commit-Position: refs/heads/master@{#308175} TBR=derat@chromium.org,dnicoara@chromium.org NOTREECHECKS=true NOTRY=true BUG=429746 Committed: https://crrev.com/8dfe0b37a1871849c2f60bddcc8c1853f658a595 Cr-Commit-Position: refs/heads/master@{#308195}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+591 lines, -595 lines) Patch
M ui/display/chromeos/display_configurator.h View 10 chunks +51 lines, -54 lines 0 comments Download
M ui/display/chromeos/display_configurator.cc View 9 chunks +457 lines, -467 lines 0 comments Download
M ui/display/chromeos/display_configurator_unittest.cc View 14 chunks +83 lines, -74 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
samuong
Created Revert of Update DisplayConfigurator to use the asynchronous tasks
6 years ago (2014-12-12 23:45:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797383002/1
6 years ago (2014-12-12 23:47:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 23:49:27 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-12 23:50:12 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8dfe0b37a1871849c2f60bddcc8c1853f658a595
Cr-Commit-Position: refs/heads/master@{#308195}

Powered by Google App Engine
This is Rietveld 408576698