Issue 797373004: Early error out if the 'msvs' is specified in GYP_GENERATORS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 797373004: Early error out if the 'msvs' is specified in GYP_GENERATORS (Closed)

Created:
5 years, 11 months ago by scottmg

Modified:
5 years, 11 months ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Early error out if the 'msvs' is specified in GYP_GENERATORS This generator hasn't worked for a long time, but it's not obvious that it doesn't work which can be confusing. R=thakis@chromium.org BUG=446912 Committed: https://crrev.com/df96803de2cef0a192ed5eb974d6d21400db5d8f Cr-Commit-Position: refs/heads/master@{#310421}

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	build/gyp_chromium	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797373004/1

5 years, 11 months ago (2015-01-07 23:34:14 UTC) #4

commit-bot: I haz the power

5 years, 11 months ago (2015-01-08 00:37:46 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/df96803de2cef0a192ed5eb974d6d21400db5d8f
Cr-Commit-Position: refs/heads/master@{#310421}