Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 797313003: Call av_log_set_level() after loading ffmpegsumo.dll. (Closed)

Created:
6 years ago by scherkus (not reviewing)
Modified:
6 years ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Call av_log_set_level() after loading ffmpegsumo.dll. Doing so forces the library to load and triggers our FMA3-disabling code. BUG=440892 Committed: https://crrev.com/83270658e53672ee89952ded667f854bcb6dafcf Cr-Commit-Position: refs/heads/master@{#308216}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M media/base/media_win.cc View 2 chunks +15 lines, -2 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
scherkus (not reviewing)
6 years ago (2014-12-12 22:12:59 UTC) #2
DaleCurtis
lgtm https://codereview.chromium.org/797313003/diff/1/media/base/media_win.cc File media/base/media_win.cc (right): https://codereview.chromium.org/797313003/diff/1/media/base/media_win.cc#newcode41 media/base/media_win.cc:41: // VS2013 has a bug where FMA3 instructions ...
6 years ago (2014-12-12 22:58:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797313003/1
6 years ago (2014-12-12 23:01:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-13 01:35:54 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-13 01:36:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83270658e53672ee89952ded667f854bcb6dafcf
Cr-Commit-Position: refs/heads/master@{#308216}

Powered by Google App Engine
This is Rietveld 408576698