[Events] Propagate IME composition event to JS on Android.

[Events] Propagate IME composition event to JS on Android.

Fixing Stable blocker for Clank IME.

The companion Chrome CL is https://codereview.chromium.org/842493004/

BUG=422685
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188259

[huangs, 2015-01-12 20:22:15]

huangs@chromium.org changed reviewers:
+ bcwhite@chromium.org, suzhe@chromium.org

[bcwhite, 2015-01-12 21:02:44]

non-expert-or-owner LGTM

https://codereview.chromium.org/797243003/diff/1/Source/core/events/KeyboardE...
File Source/core/events/KeyboardEvent.cpp (right):

https://codereview.chromium.org/797243003/diff/1/Source/core/events/KeyboardE...
Source/core/events/KeyboardEvent.cpp:34: int
kInputMethodEditorCompositionKeyCode = 229;
Is this constant available anywhere else already or can it be read from Android
SDK code?

https://codereview.chromium.org/797243003/diff/1/Source/core/events/KeyboardE...
Source/core/events/KeyboardEvent.cpp:175: #if OS(ANDROID)
// TODO: Check if this applies to other OS

[huangs, 2015-01-12 23:25:57]

Updated and shortened.

OWNER review to eae@, PTAL.  Thanks!

https://codereview.chromium.org/797243003/diff/1/Source/core/events/KeyboardE...
File Source/core/events/KeyboardEvent.cpp (right):

https://codereview.chromium.org/797243003/diff/1/Source/core/events/KeyboardE...
Source/core/events/KeyboardEvent.cpp:34: int
kInputMethodEditorCompositionKeyCode = 229;
Searched for 229 and 0xE5.  Something close is

https://code.google.com/p/chromium/codesearch#chromium/src/content/shell/rend...

which calls it VKEY_PROCESSKEY, but still defines it anyway.

Copying the style to reduce delta, and to facilitate future refactoring.

https://codereview.chromium.org/797243003/diff/1/Source/core/events/KeyboardE...
Source/core/events/KeyboardEvent.cpp:175: #if OS(ANDROID)
On 2015/01/12 21:02:44, bcwhite wrote:
> // TODO: Check if this applies to other OS

Done (using FIXME instead).

[huangs, 2015-01-12 23:26:31]

huangs@chromium.org changed reviewers:
+ eae@chromium.org

[eae, 2015-01-12 23:41:04]

Would like to see a test for this but code change lgtm.

[huangs, 2015-01-12 23:43:02]

The CQ bit was checked by huangs@chromium.org

[commit-bot: I haz the power, 2015-01-12 23:43:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/797243003/20001

[huangs, 2015-01-12 23:48:43]

Thanks. Submitting!

[commit-bot: I haz the power, 2015-01-13 00:58:13]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188259