Make FlushICache NOP for Nvidia Denver CPU's.

src/arm64/assembler-arm64.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
@@ skipping 27 matching lines @@
 
 namespace v8 {
 namespace internal {
 
 
 // -----------------------------------------------------------------------------
 // CpuFeatures implementation.
 
 void CpuFeatures::ProbeImpl(bool cross_compile) {
   // AArch64 has no configuration options, no further probing is required.
   supported_ = 0;

[JF, 2014/12/15 16:23:23]

The ARM and x64 version of this file also have:


  // Only use statically determined features for cross compile (snapshot).
  if (cross_compile) return;

Shoud this fie also do this?

[rmcilroy, 2014/12/15 16:32:02]

Yes you will need this here otherwise the snapshot might get generated wrongly.

[arajp, 2014/12/18 13:25:05]

Done.

+  // Probe for runtime features
+  base::CPU cpu;
+  if (cpu.implementer() == base::CPU::NVIDIA &&
+      cpu.variant() == base::CPU::NV_VARIANT_DENVER)
+    supported_ |= 1u << COHERENT_CACHE;

[Benedikt Meurer, 2014/12/15 05:33:36]

Nit: Add { and } for block.

[arajp, 2014/12/18 13:25:05]

Done.

 }
 
 
 void CpuFeatures::PrintTarget() { }
 void CpuFeatures::PrintFeatures() { }
 
 
 // -----------------------------------------------------------------------------
 // CPURegList utilities.
 
@@ skipping 3070 matching lines @@
   movz(scratch, (target_offset >> 16) & 0xFFFF, 16);
   movk(scratch, (target_offset >> 32) & 0xFFFF, 32);
   DCHECK((target_offset >> 48) == 0);
   add(rd, rd, scratch);
 }
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_ARM64