Provides an API to cope with table headers in Accessibility

Provides an API to cope with table headers in Accessibility

Updating AXTable to have rowHeaders method together with columnHeaders.

BUG=441706
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187738

[k.czech, 2014-12-16 19:20:10]

k.czech@samsung.com changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2014-12-17 01:05:57]

https://codereview.chromium.org/797223002/diff/1/public/web/WebAXObject.h
File public/web/WebAXObject.h (right):

https://codereview.chromium.org/797223002/diff/1/public/web/WebAXObject.h#new...
public/web/WebAXObject.h:208: BLINK_EXPORT void
tableHeaders(WebVector<WebAXObject>&, bool) const;
You need to name parameters when they're non-obvious, so this should be "bool
rowHeaders"

However, I think I'd prefer two separate functions here: rowHeaders and
columnHeaders - rather than passing false and true. This is the "public" API for
Blink so clarity and readability are quite important

[k.czech, 2014-12-19 11:12:51]

On 2014/12/17 01:05:57, dmazzoni wrote:
> https://codereview.chromium.org/797223002/diff/1/public/web/WebAXObject.h
> File public/web/WebAXObject.h (right):
> 
>
https://codereview.chromium.org/797223002/diff/1/public/web/WebAXObject.h#new...
> public/web/WebAXObject.h:208: BLINK_EXPORT void
> tableHeaders(WebVector<WebAXObject>&, bool) const;
> You need to name parameters when they're non-obvious, so this should be "bool
> rowHeaders"
> 
> However, I think I'd prefer two separate functions here: rowHeaders and
> columnHeaders - rather than passing false and true. This is the "public" API
for
> Blink so clarity and readability are quite important

Thanks, you are right.
Applied all the suggestions.

[dmazzoni, 2014-12-19 19:02:35]

dmazzoni@chromium.org changed reviewers:
+ jochen@chromium.org

[dmazzoni, 2014-12-19 19:02:36]

lgtm

+jochen for owners review of public/

https://codereview.chromium.org/797223002/diff/20001/public/web/WebAXObject.h
File public/web/WebAXObject.h (right):

https://codereview.chromium.org/797223002/diff/20001/public/web/WebAXObject.h...
public/web/WebAXObject.h:200: BLINK_EXPORT void
rowHeaders(WebVector<WebAXObject>&) const;
The comment above this group of functions implies these functions are supposed
to be called on the <row> - but your API is meant to be called on the <table>,
so rowHeaders and columnHeaders should be above, in the section labeled "// For
a table".

[jochen (gone - plz use gerrit), 2014-12-22 14:31:44]

lgtm

[k.czech, 2014-12-29 10:05:33]

On 2014/12/19 19:02:36, dmazzoni wrote:
> lgtm
> 
> +jochen for owners review of public/
> 
> https://codereview.chromium.org/797223002/diff/20001/public/web/WebAXObject.h
> File public/web/WebAXObject.h (right):
> 
>
https://codereview.chromium.org/797223002/diff/20001/public/web/WebAXObject.h...
> public/web/WebAXObject.h:200: BLINK_EXPORT void
> rowHeaders(WebVector<WebAXObject>&) const;
> The comment above this group of functions implies these functions are supposed
> to be called on the <row> - but your API is meant to be called on the <table>,
> so rowHeaders and columnHeaders should be above, in the section labeled "//
For
> a table".

Yes you are right. Applied all suggestions. Thanks.

[k.czech, 2014-12-29 10:06:15]

The CQ bit was checked by k.czech@samsung.com

[commit-bot: I haz the power, 2014-12-29 10:06:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/797223002/40001

[commit-bot: I haz the power, 2014-12-29 11:20:07]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187738