Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1264)

Unified Diff: extensions/renderer/resources/binding.js

Issue 797183005: Add a mimeHandler extension API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@streams-lifetime
Patch Set: rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/resources/binding.js
diff --git a/extensions/renderer/resources/binding.js b/extensions/renderer/resources/binding.js
index 9804b617a4f3fb24a6f0ec26a7adbecd1a57c917..b1a3efcaca5002bb03d2918acec145572dd74e81 100644
--- a/extensions/renderer/resources/binding.js
+++ b/extensions/renderer/resources/binding.js
@@ -77,11 +77,15 @@ APIFunctions.prototype.setHandleRequestWithPromise =
return module.createKeepAlive();
});
$Function.apply(customizedFunction, this, args).then(function(result) {
- sendRequestHandler.safeCallbackApply(
- name, {'stack': stack}, callback, [result]);
+ if (callback) {
+ sendRequestHandler.safeCallbackApply(name, {'stack': stack}, callback,
+ [result]);
+ }
}).catch(function(error) {
- var message = exceptionHandler.safeErrorToString(error, true);
- lastError.run(name, message, stack, callback);
+ if (callback) {
+ var message = exceptionHandler.safeErrorToString(error, true);
+ lastError.run(name, message, stack, callback);
+ }
}).then(function() {
keepAlivePromise.then(function(keepAlive) {
keepAlive.close();

Powered by Google App Engine
This is Rietveld 408576698