Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 797173003: win: implement Semaphore (Closed)

Created:
6 years ago by scottmg
Modified:
6 years ago
Reviewers:
Mark Mentovai
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : pcheck #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M util/synchronization/semaphore.h View 2 chunks +4 lines, -0 lines 0 comments Download
M util/synchronization/semaphore.cc View 1 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scottmg
https://codereview.chromium.org/797173003/diff/1/util/synchronization/semaphore.cc File util/synchronization/semaphore.cc (right): https://codereview.chromium.org/797173003/diff/1/util/synchronization/semaphore.cc#newcode20 util/synchronization/semaphore.cc:20: #include "base/posix/eintr_wrapper.h" I didn't realize before, but this guards ...
6 years ago (2014-12-17 22:58:15 UTC) #1
Mark Mentovai
LGTM. https://codereview.chromium.org/797173003/diff/1/util/synchronization/semaphore.cc File util/synchronization/semaphore.cc (right): https://codereview.chromium.org/797173003/diff/1/util/synchronization/semaphore.cc#newcode58 util/synchronization/semaphore.cc:58: CHECK_EQ(WaitForSingleObject(semaphore_, INFINITE), WAIT_OBJECT_0); PCHECK this and ReleaseSemaphore()?
6 years ago (2014-12-18 14:38:47 UTC) #2
scottmg
https://codereview.chromium.org/797173003/diff/1/util/synchronization/semaphore.cc File util/synchronization/semaphore.cc (right): https://codereview.chromium.org/797173003/diff/1/util/synchronization/semaphore.cc#newcode58 util/synchronization/semaphore.cc:58: CHECK_EQ(WaitForSingleObject(semaphore_, INFINITE), WAIT_OBJECT_0); On 2014/12/18 14:38:47, Mark Mentovai wrote: ...
6 years ago (2014-12-18 17:07:03 UTC) #3
scottmg
6 years ago (2014-12-18 17:09:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
d1fdcf99e0026b8b87b468d6b778d1c796eaaf8a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698