Issue 797113002: Toggling 'Open in a tab' now works for hosted apps on chrome://apps page.

Issue 797113002: Toggling 'Open in a tab' now works for hosted apps on chrome://apps page. (Closed)

Created:
6 years ago by mitchellj

Modified:
6 years ago

Reviewers:
Evan Stade

CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, arv+watch_chromium.org, pedrosimonetti+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Toggling 'Open in a tab' now works for hosted apps on chrome://apps page. BUG=441561 Committed: https://crrev.com/a72f0539728eb1d3307e3dfc8e8c40295ab20d1b Cr-Commit-Position: refs/heads/master@{#308453}

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	chrome/browser/resources/ntp4/apps_page.js	View		1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 9 (2 generated)

Evan Stade

On 2014/12/12 02:20:36, mitchellj wrote: > Evan, could you please take a look at this? ...

6 years ago (2014-12-12 19:51:26 UTC) #3

mitchellj

On 2014/12/12 19:51:26, Evan Stade wrote: > On 2014/12/12 02:20:36, mitchellj wrote: > > Evan, ...

6 years ago (2014-12-15 01:39:07 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797113002/1

6 years ago (2014-12-15 22:29:25 UTC) #7

commit-bot: I haz the power

6 years ago (2014-12-15 23:25:50 UTC) #9

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/a72f0539728eb1d3307e3dfc8e8c40295ab20d1b
Cr-Commit-Position: refs/heads/master@{#308453}