Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Unified Diff: sky/tools/tester/test_runner.cc

Issue 797063002: Make reftests work for sky. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: address review comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/tools/tester/test_runner.h ('k') | sky/tools/tester/tester.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tools/tester/test_runner.cc
diff --git a/sky/tools/tester/test_runner.cc b/sky/tools/tester/test_runner.cc
index 78125ee67fd6dfa9521ff39345591391129bf80e..4f948be4c0b4a03c7a2fafc6a72a6b7051beb529 100644
--- a/sky/tools/tester/test_runner.cc
+++ b/sky/tools/tester/test_runner.cc
@@ -17,10 +17,11 @@ TestRunnerClient::~TestRunnerClient() {
}
TestRunner::TestRunner(TestRunnerClient* client, mojo::View* container,
- const std::string& url)
+ const std::string& url, bool enable_pixel_dumping)
: test_harness_factory_(this),
client_(client),
- weak_ptr_factory_(this) {
+ weak_ptr_factory_(this),
+ enable_pixel_dumping_(enable_pixel_dumping) {
CHECK(client);
scoped_ptr<mojo::ServiceProviderImpl> exported_services(
@@ -42,10 +43,22 @@ void TestRunner::OnTestStart() {
std::cout.flush();
}
-void TestRunner::OnTestComplete(const std::string& test_result) {
+void TestRunner::OnTestComplete(const std::string& test_result,
+ const mojo::Array<uint8_t>& pixels) {
std::cout << "Content-Type: text/plain\n";
std::cout << test_result << "\n";
std::cout << "#EOF\n";
+
+ // TODO(ojan): Don't generate the pixels if enable_pixel_dumping_ is false.
+ if (enable_pixel_dumping_) {
+ // TODO(ojan): Add real hashes here once we want to do pixel tests.
+ std::cout << "\nActualHash: FAKEHASHSTUB\n";
+ std::cout << "Content-Type: image/png\n";
+ std::cout << "Content-Length: " << pixels.size() << "\n";
+ std::cout.write(
+ reinterpret_cast<const char*>(&pixels[0]), pixels.size());
+ }
+
std::cout << "#EOF\n";
std::cout.flush();
std::cerr << "#EOF\n";
« no previous file with comments | « sky/tools/tester/test_runner.h ('k') | sky/tools/tester/tester.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698