Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 797043002: Add sbix font to coloremoji gm. (Closed)

Created:
6 years ago by bungeman-skia
Modified:
5 years, 10 months ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add regional indicators. #

Patch Set 3 : Rebase. #

Patch Set 4 : Line lengths. #

Total comments: 2

Patch Set 5 : Create string from explicit utf-8. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -88 lines) Patch
M gm/coloremoji.cpp View 1 2 3 4 2 chunks +100 lines, -88 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
bungeman-skia
This adds a test for 'sbix' fonts, but this only works on Mac due to ...
5 years, 11 months ago (2015-01-26 21:00:04 UTC) #2
reed1
lgtm w/ request for 7-bit readable version. https://codereview.chromium.org/797043002/diff/60001/gm/coloremoji.cpp File gm/coloremoji.cpp (right): https://codereview.chromium.org/797043002/diff/60001/gm/coloremoji.cpp#newcode70 gm/coloremoji.cpp:70: emojiFonts[1].text = ...
5 years, 11 months ago (2015-01-26 21:04:40 UTC) #3
bungeman-skia
https://codereview.chromium.org/797043002/diff/60001/gm/coloremoji.cpp File gm/coloremoji.cpp (right): https://codereview.chromium.org/797043002/diff/60001/gm/coloremoji.cpp#newcode70 gm/coloremoji.cpp:70: emojiFonts[1].text = "πŸ’°πŸ‘πŸŽ…πŸͺπŸ•πŸš€πŸš»πŸ’©πŸ“·πŸ“¦πŸ‡ΊπŸ‡ΈπŸ‡¦"; On 2015/01/26 21:04:40, reed1 wrote: > ...
5 years, 11 months ago (2015-01-26 22:01:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797043002/80001
5 years, 11 months ago (2015-01-26 22:03:38 UTC) #6
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://skia.googlesource.com/skia/+/6bdc9cd003ccba5e19ba1fc4fbe37aa676db9d53
5 years, 11 months ago (2015-01-26 22:08:55 UTC) #7
robertphillips
This CL increased the size of the GM image but doesn't appear to make use ...
5 years, 10 months ago (2015-01-28 13:11:32 UTC) #9
robertphillips
5 years, 10 months ago (2015-01-28 13:19:11 UTC) #10
Message was sent while issue was closed.
Scratch that. On the S4, Xoom and N7 the extra space is blank. On the MacMinis
it has color emoji. On all other platforms it has some form of 'X', empty box or
partial box.

Powered by Google App Engine
This is Rietveld 408576698