Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1150)

Issue 797023006: s/app_shell_browsertests/extensions_browsertests/g (Closed)

Created:
5 years, 11 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 11 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

s/app_shell_browsertests/extensions_browsertests/g We would like to use app_shell as the basis for all content-browser integration tests within the extensions layer. This simply moves the test target up to the parent //extensions path and renames it to extensions_browsertests BUG=388893 R=yoz@chromium.org Committed: https://crrev.com/ea9df2af195b5b08909dc30e05bab95f6cfcd66f Cr-Commit-Position: refs/heads/master@{#312669}

Patch Set 1 #

Total comments: 4

Patch Set 2 : preserve ordering conventions #

Patch Set 3 : merge #

Patch Set 4 : merge again! #

Patch Set 5 : add missing test support dependency #

Patch Set 6 : Fix gyp on android #

Patch Set 7 : move extenisons tests to new gyp file to break mac circular gyp deps #

Patch Set 8 : merge, actually add extensions_tests.gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+323 lines, -244 lines) Patch
M build/all.gyp View 1 2 3 4 5 6 7 2 chunks +4 lines, -2 lines 0 comments Download
M extensions/BUILD.gn View 1 2 3 4 1 chunk +62 lines, -0 lines 0 comments Download
M extensions/extensions.gyp View 1 2 3 4 5 6 2 chunks +1 line, -151 lines 0 comments Download
A extensions/extensions_tests.gyp View 1 2 3 4 5 6 7 1 chunk +233 lines, -0 lines 0 comments Download
M extensions/shell/app_shell.gyp View 1 2 3 1 chunk +0 lines, -68 lines 0 comments Download
M extensions/shell/test/shell_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/test/data/system/cpu/test_cpu_api.js View 1 chunk +1 line, -1 line 0 comments Download
M extensions/test/data/system/display/test_display_api.js View 1 chunk +1 line, -1 line 0 comments Download
M extensions/test/data/system/memory/test_memory_api.js View 1 chunk +1 line, -1 line 0 comments Download
M extensions/test/data/system/storage/test_storage_api.js View 1 chunk +1 line, -1 line 0 comments Download
M extensions/test/data/system/storage_attachment/test_storage_api.js View 1 chunk +1 line, -1 line 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 1 5 chunks +3 lines, -3 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 6 chunks +3 lines, -3 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 1 chunk +1 line, -1 line 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 1 4 chunks +2 lines, -2 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 1 3 chunks +2 lines, -2 lines 0 comments Download
M testing/buildbot/chromium.win.json View 1 2 3 4 5 6 7 10 chunks +5 lines, -5 lines 0 comments Download
M testing/buildbot/chromium_trybot.json View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (8 generated)
Ken Rockot(use gerrit already)
Yoyo, could you please take a look?
5 years, 11 months ago (2015-01-21 21:49:21 UTC) #1
Yoyo Zhou
LGTM https://codereview.chromium.org/797023006/diff/1/extensions/extensions.gyp File extensions/extensions.gyp (right): https://codereview.chromium.org/797023006/diff/1/extensions/extensions.gyp#newcode1369 extensions/extensions.gyp:1369: 'shell/test/shell_apitest.cc', We should think about whether shell/test is ...
5 years, 11 months ago (2015-01-21 23:47:01 UTC) #2
Ken Rockot(use gerrit already)
https://codereview.chromium.org/797023006/diff/1/extensions/extensions.gyp File extensions/extensions.gyp (right): https://codereview.chromium.org/797023006/diff/1/extensions/extensions.gyp#newcode1369 extensions/extensions.gyp:1369: 'shell/test/shell_apitest.cc', On 2015/01/21 23:47:01, Yoyo Zhou wrote: > We ...
5 years, 11 months ago (2015-01-22 00:22:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797023006/140001
5 years, 11 months ago (2015-01-22 06:25:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/37527)
5 years, 11 months ago (2015-01-22 06:31:54 UTC) #7
Ken Rockot(use gerrit already)
jochen@ could you please take a look for build and testing/buildbot? Thanks!
5 years, 11 months ago (2015-01-22 15:08:35 UTC) #9
jochen (gone - plz use gerrit)
lgtm would you mind swarming those tests btw?
5 years, 11 months ago (2015-01-22 16:25:49 UTC) #10
Ken Rockot(use gerrit already)
On 2015/01/22 16:25:49, jochen (slow) wrote: > lgtm > > would you mind swarming those ...
5 years, 11 months ago (2015-01-22 16:40:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797023006/140001
5 years, 11 months ago (2015-01-22 16:41:59 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/37526)
5 years, 11 months ago (2015-01-22 16:42:32 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797023006/140001
5 years, 11 months ago (2015-01-22 18:29:06 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/116625) linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/102427)
5 years, 11 months ago (2015-01-22 18:48:33 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797023006/140001
5 years, 11 months ago (2015-01-22 20:25:30 UTC) #21
commit-bot: I haz the power
Committed patchset #8 (id:140001)
5 years, 11 months ago (2015-01-22 20:27:03 UTC) #22
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 20:29:02 UTC) #23
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/ea9df2af195b5b08909dc30e05bab95f6cfcd66f
Cr-Commit-Position: refs/heads/master@{#312669}

Powered by Google App Engine
This is Rietveld 408576698