Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 797013002: Make CSSSupportsRule function arguments non-optional (Closed)

Created:
6 years ago by philipj_slow
Modified:
6 years ago
Reviewers:
Timothy Loh
CC:
blink-reviews, arv+blink, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, Inactive, darktears, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make CSSSupportsRule function arguments non-optional http://dev.w3.org/csswg/css-conditional/#the-csssupportsrule-interface http://dev.w3.org/csswg/css-conditional/#the-cssconditionrule-interface http://dev.w3.org/csswg/css-conditional/#the-cssgroupingrule-interface Per spec CSSSupportsRule and CSSMediaRule inherits from CSSConditionRule which inherits from CSSGroupingRule, which is where insertRule() and deleteRule() live. We expose neither CSSConditionRule nor CSSGroupingRule, but this change aligns CSSSupportsRule with CSSMediaRule, so that introducing CSSGroupingRule becomes a smaller change. Firefox Nightly already throws exceptions when insertRule() or deleteRule() arguments are omitted. IE11 does not support @supports. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187121

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M LayoutTests/css3/supports-cssom.html View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/css3/supports-cssom-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/css/CSSSupportsRule.idl View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
philipj_slow
6 years ago (2014-12-12 11:54:38 UTC) #2
Timothy Loh
On 2014/12/12 11:54:38, philipj wrote: lgtm
6 years ago (2014-12-14 23:19:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797013002/1
6 years ago (2014-12-15 06:47:02 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-15 08:49:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187121

Powered by Google App Engine
This is Rietveld 408576698