Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 797003002: Replaced @benchmark.Enabled/Disabled and @test.Enabled/Disabled with @decorators.Enabled/Disabled i… (Closed)

Created:
6 years ago by sullivan
Modified:
6 years ago
Reviewers:
dtu
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replaced @benchmark.Enabled/Disabled and @test.Enabled/Disabled with @decorators.Enabled/Disabled in all unit tests BUG= Committed: https://crrev.com/a172a0945ee32467689e0eb42bbfd2b86964d732 Cr-Commit-Position: refs/heads/master@{#308607}

Patch Set 1 #

Patch Set 2 : Removed test.py file so that no one uses this deprecated decorator #

Patch Set 3 : rebase #

Patch Set 4 : fixed some bad imports #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -126 lines) Patch
M tools/perf/measurements/oilpan_gc_times_unittest.py View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/measurements/rasterize_and_record_micro_unittest.py View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/record_per_area_unittest.py View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/repaint_unittest.py View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/skpicture_printer_unittest.py View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/smoothness_unittest.py View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/thread_times_unittest.py View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/cros_unittest.py View 5 chunks +6 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/tracing_backend_unittest.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_memory_unittest.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_network_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/bitmap_unittest.py View 8 chunks +8 lines, -8 lines 0 comments Download
M tools/telemetry/telemetry/core/browser_unittest.py View 7 chunks +9 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/android_platform_backend_unittest.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/cros_interface_unittest.py View 9 chunks +14 lines, -14 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/mac_platform_backend_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/platform_backend_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/posix_platform_backend_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/powermetrics_power_monitor_unittest.py View 3 chunks +5 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper_unittest.py View 4 chunks +6 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/android_systrace_profiler_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/vtune_profiler_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/tab_unittest.py View 5 chunks +6 lines, -6 lines 0 comments Download
M tools/telemetry/telemetry/core/video_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/action_runner_unittest.py View 5 chunks +5 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/scroll_unittest.py View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/page_test_unittest.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/unittest_util/disabled_cases.py View 1 2 3 2 chunks +13 lines, -13 lines 0 comments Download
D tools/telemetry/telemetry/unittest_util/test.py View 1 1 chunk +0 lines, -8 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 28 (13 generated)
sullivan
6 years ago (2014-12-12 02:08:40 UTC) #5
dtu
Can you remove unittest_util/test.py in this patch? This was the only thing it was used ...
6 years ago (2014-12-12 23:20:52 UTC) #6
dtu
Otherwise lgtm :D
6 years ago (2014-12-12 23:21:03 UTC) #7
sullivan
On 2014/12/12 23:20:52, dtu wrote: > Can you remove unittest_util/test.py in this patch? This was ...
6 years ago (2014-12-15 15:15:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797003002/20001
6 years ago (2014-12-15 15:16:41 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/14927)
6 years ago (2014-12-15 20:37:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797003002/20001
6 years ago (2014-12-15 20:40:38 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/15038)
6 years ago (2014-12-16 00:16:40 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797003002/40001
6 years ago (2014-12-16 01:51:58 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/15156)
6 years ago (2014-12-16 04:58:00 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797003002/60001
6 years ago (2014-12-16 15:06:27 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/18811)
6 years ago (2014-12-16 16:48:27 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797003002/60001
6 years ago (2014-12-16 16:54:30 UTC) #26
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years ago (2014-12-16 17:39:41 UTC) #27
commit-bot: I haz the power
6 years ago (2014-12-16 17:40:17 UTC) #28
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a172a0945ee32467689e0eb42bbfd2b86964d732
Cr-Commit-Position: refs/heads/master@{#308607}

Powered by Google App Engine
This is Rietveld 408576698