Issue 796983002: Move file_util to be POSIX-only

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 796983002: Move file_util to be POSIX-only (Closed)

Created:
6 years ago by scottmg

Modified:
6 years ago

Reviewers:
Mark Mentovai

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/mini_chromium@string-convert-cast

Target Ref:
refs/heads/master

Project:
mini_chromium

Visibility:
Public.

More Reviews

Description

Move file_util to be POSIX-only Only contains functionality likely to be used on POSIX and more or less matches the current Chromium implementation. R=mark@chromium.org BUG=crashpad:1 Committed: https://chromium.googlesource.com/chromium/mini_chromium/+/e80af61c07c0ebcf15f733ef2bd4b83db48c3ee3

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -26 lines)			Patch
M	base/base.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/file_util.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
D	base/file_util.cc	View	1 chunk	+0 lines, -26 lines	0 comments	Download
A +	base/file_util_posix.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM. Separately, we should move it into base/files, because that’s what happened to it in ...

6 years ago (2014-12-11 21:00:55 UTC) #2

scottmg

Committed patchset #1 (id:1) manually as e80af61c07c0ebcf15f733ef2bd4b83db48c3ee3 (presubmit successful).

6 years ago (2014-12-11 21:02:42 UTC) #3

scottmg

6 years ago (2014-12-11 21:02:48 UTC) #4

Message was sent while issue was closed.

On 2014/12/11 21:00:55, Mark Mentovai wrote:
> LGTM. Separately, we should move it into base/files, because that’s what
> happened to it in upstream Chromium.

Sure, will do.

Expand Messages | Collapse Messages