Move Load() from HTMLDocument::OnEmbed() to the constructor.

Move Load() from HTMLDocument::OnEmbed() to the constructor.

TBR=aa@chromium.org

Committed: https://crrev.com/f7ec382c0c65e1b07c3a99cfc87262dcb8c946bc
Cr-Commit-Position: refs/heads/master@{#308070}

[xhwang, 2014-12-12 01:53:35]

xhwang@chromium.org changed reviewers:
+ qsr@chromium.org

[xhwang, 2014-12-12 01:53:36]

FYI only

[Aaron Boodman, 2014-12-12 05:32:56]

This seems right to me. Sorry I didn't notice this in the review.

-a (phone)
On Dec 11, 2014 5:53 PM, <xhwang@chromium.org> wrote:

> Reviewers: qsr,
>
> Message:
> FYI only
>
> Description:
> Move Load() from HTMLDocument::OnEmbed() to the constructor.
>
> BUG=
> TEST=
>
> Please review this at https://codereview.chromium.org/796963003/
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+1, -2 lines):
>   M mojo/services/html_viewer/html_document.cc
>
>
> Index: mojo/services/html_viewer/html_document.cc
> diff --git a/mojo/services/html_viewer/html_document.cc
> b/mojo/services/html_viewer/html_document.cc
> index 1c9a00bc713a1b018f49d157de42463268b7a19a..
> eb9185e86f92cfa9975877dc7fa31dfe38fd07e3 100644
> --- a/mojo/services/html_viewer/html_document.cc
> +++ b/mojo/services/html_viewer/html_document.cc
> @@ -101,6 +101,7 @@ HTMLDocument::HTMLDocument(
>    exported_services_.AddService(this);
>    exported_services_.AddService(&view_manager_client_factory_);
>    WeakBindToPipe(&exported_services_, provider.PassMessagePipe());
> +  Load(response_.Pass());
>  }
>
>  HTMLDocument::~HTMLDocument() {
> @@ -121,8 +122,6 @@ void HTMLDocument::OnEmbed(
>    embedder_service_provider_ = embedder_service_provider.Pass();
>    navigator_host_.set_service_provider(embedder_service_provider_.get());
>
> -  Load(response_.Pass());
> -
>    blink::WebSize root_size(root_->bounds().width,
> root_->bounds().height);
>    web_view_->resize(root_size);
>    web_layer_tree_view_impl_->setViewportSize(root_size);
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[qsr, 2014-12-12 09:10:30]

LGTM, sorry about this.

[qsr, 2014-12-12 09:10:32]

The CQ bit was checked by qsr@chromium.org

[commit-bot: I haz the power, 2014-12-12 09:11:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/796963003/1

[commit-bot: I haz the power, 2014-12-12 14:36:22]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-12-12 14:37:55]

Patchset 1 (id:??) landed as
https://crrev.com/f7ec382c0c65e1b07c3a99cfc87262dcb8c946bc
Cr-Commit-Position: refs/heads/master@{#308070}