Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1248)

Unified Diff: chrome/browser/background/background_mode_manager.cc

Issue 796963002: Instrument some of the exit paths likely to suffer hangs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@end_session_instrument
Patch Set: Add instrumentation for browser exit, plus now actually compiles Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/background/background_mode_manager.cc
diff --git a/chrome/browser/background/background_mode_manager.cc b/chrome/browser/background/background_mode_manager.cc
index b95f598ce8ff0232f1bab13416711b47e5772e2a..1e3f2d1b00e8d2697f372ff3ead520c74bd1394b 100644
--- a/chrome/browser/background/background_mode_manager.cc
+++ b/chrome/browser/background/background_mode_manager.cc
@@ -53,6 +53,10 @@
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/resource/resource_bundle.h"
+#if defined(OS_WIN)
+#include "components/browser_watcher/exit_funnel_win.h"
+#endif
+
using base::UserMetricsAction;
using extensions::Extension;
using extensions::UpdatedExtensionPermissionsInfo;
@@ -532,6 +536,10 @@ void BackgroundModeManager::ExecuteCommand(int command_id, int event_flags) {
}
break;
case IDC_EXIT:
+#if defined(OS_WIN)
+ browser_watcher::ExitFunnel::RecordSingleEvent(
+ chrome::kBrowserExitCodesRegistryPath, L"TraybarExit");
+#endif
content::RecordAction(UserMetricsAction("Exit"));
chrome::CloseAllBrowsers();
break;
@@ -638,6 +646,11 @@ void BackgroundModeManager::UpdateKeepAliveAndTrayIcon() {
if (!keeping_alive_) {
keeping_alive_ = true;
chrome::IncrementKeepAliveCount();
+
+#if defined(OS_WIN)
+ browser_watcher::ExitFunnel::RecordSingleEvent(
+ chrome::kBrowserExitCodesRegistryPath, L"BackgroundOn");
+#endif
}
CreateStatusTrayIcon();
return;
@@ -647,6 +660,11 @@ void BackgroundModeManager::UpdateKeepAliveAndTrayIcon() {
if (keeping_alive_) {
keeping_alive_ = false;
chrome::DecrementKeepAliveCount();
+
+#if defined(OS_WIN)
+ browser_watcher::ExitFunnel::RecordSingleEvent(
+ chrome::kBrowserExitCodesRegistryPath, L"BackgroundOff");
+#endif
}
}
« no previous file with comments | « no previous file | chrome/browser/lifetime/application_lifetime.cc » ('j') | chrome/chrome_watcher/chrome_watcher_main.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698