Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 796923002: Unfriend views::internal::RootView from views::ViewTargeter (Closed)

Created:
6 years ago by tdanderson
Modified:
6 years ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unfriend views::internal::RootView from views::ViewTargeter No longer necessary, so unfriend and delete the associated TODO. BUG=none TEST=none Committed: https://crrev.com/965db6c64a158fd5c544e459c225f45576f11a39 Cr-Commit-Position: refs/heads/master@{#307957}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M ui/views/view_targeter.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tdanderson
Sadrul, PTAL.
6 years ago (2014-12-11 18:13:23 UTC) #2
sadrul
lgtm
6 years ago (2014-12-11 18:47:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796923002/1
6 years ago (2014-12-11 18:59:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-11 19:59:58 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-11 20:01:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/965db6c64a158fd5c544e459c225f45576f11a39
Cr-Commit-Position: refs/heads/master@{#307957}

Powered by Google App Engine
This is Rietveld 408576698