pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart - Issue 796913004: enhance code completion tracking and measurement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

Issue 796913004: enhance code completion tracking and measurement (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: merge Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/completion_manager.dart ('k') | pkg/analysis_server/test/domain_completion_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart b/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

index 3fe13389a326cbd3f3f9735a49ff745935808846..f20a87721bc0d4351b0f8fb41d77f461fa5e3184 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

@@ -75,10 +75,12 @@ class DartCompletionManager extends CompletionManager {

}

@override

- void computeCache() {

- waitForAnalysis().then((CompilationUnit unit) {

+ Future<bool> computeCache() {

+ return waitForAnalysis().then((CompilationUnit unit) {

if (unit != null && !cache.isImportInfoCached(unit)) {

- cache.computeImportInfo(unit, searchEngine);

+ return cache.computeImportInfo(unit, searchEngine);

+ } else {

+ return new Future.value(false);

}

});

}