Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Unified Diff: Source/core/dom/Fullscreen.cpp

Issue 796913002: Use C++11 range-based loop for core/clipboard, core/dom and core/testing (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rename variable Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Fullscreen.cpp
diff --git a/Source/core/dom/Fullscreen.cpp b/Source/core/dom/Fullscreen.cpp
index 07161b2523d4083a4500da08d7fa22bdc7b64615..161d606940914d71388110efb521ecd617585d43 100644
--- a/Source/core/dom/Fullscreen.cpp
+++ b/Source/core/dom/Fullscreen.cpp
@@ -339,11 +339,11 @@ void Fullscreen::exitFullscreen()
// 4. For each descendant in descendants, empty descendant's fullscreen element stack, and queue a
// task to fire an event named fullscreenchange with its bubbles attribute set to true on descendant.
- for (WillBeHeapDeque<RefPtrWillBeMember<Document> >::iterator i = descendants.begin(); i != descendants.end(); ++i) {
- ASSERT(*i);
- RequestType requestType = from(**i).m_fullScreenElementStack.last().second;
- from(**i).clearFullscreenElementStack();
- enqueueChangeEvent(**i, requestType);
+ for (auto descendant : descendants) {
dcheng 2014/12/16 19:52:51 Doesn't this end up ref and unref'ing everything i
+ ASSERT(descendant);
+ RequestType requestType = from(*descendant).m_fullScreenElementStack.last().second;
+ from(*descendant).clearFullscreenElementStack();
+ enqueueChangeEvent(*descendant, requestType);
}
// 5. While doc is not null, run these substeps:

Powered by Google App Engine
This is Rietveld 408576698